WordPress.org
Get WordPress

Making WordPress.org

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#6128 closed defect (bug) (fixed)

Meta: Use global header height variable to calculate Openverse iframe height

Reported by: sarayourfriend's profile sarayourfriend Owned by: sarayourfriend's profile sarayourfriend
Milestone: Priority: normal
Component: Openverse Keywords: has-patch
Cc:

Description

As described here ​https://github.com/WordPress/openverse-frontend/issues/834#issuecomment-1048022272 we need to use the new header height variable to fix the openverse iframe height.

Change History (5)

​zackkrida commented on ​PR #62:
3 years ago #2

@sarayourfriend as part of this could we also remove vertical overflow from the WP theme, to prevent multiple scrollbars and the wp.org footer from taking up search result screen real estate? body {overflow:hidden;} should do the trick.

​sarayourfriend commented on ​PR #62:
3 years ago #3

@WordPress/openverse Please review this when y'all have a chance this week. Thanks!

#4 @dd32
3 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 11656:

Openverse: Use global header height variable to calculate Openverse iframe height.

Props sarayourfriend, zackkrida, dhruvkb.
Closes ​https://github.com/WordPress/wordpress.org/pull/62.
Fixes #6128.

#5 @dd32
3 years ago

  • Component changed from WordPress.org Site to Openverse
Note: See TracTickets for help on using tickets.