Making WordPress.org

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#6243 closed defect (bug) (fixed)

Too much white space is coming due to the blank tag at the bottom of the page

Reported by: aezazshekh's profile aezazshekh Owned by: coffee2code's profile coffee2code
Milestone: Priority: normal
Component: Photo Directory Keywords: has-patch has-screenshots
Cc:

Description

This blank tag <footer class="entry-footer"></footer> is causing white space at the bottom of all the below pages.

https://wordpress.org/photos/faq/
https://wordpress.org/photos/submit/
https://wordpress.org/photos/guidelines/
https://wordpress.org/photos/license/

I have created a video of the issue. its link is given below.
https://www.loom.com/share/f68d9e26439e4dc3b2a7fd8ef807992c

Attachments (2)

Screenshot at Apr 01 12-17-59.png (1.1 MB) - added by aezazshekh 2 years ago.
Screenshot of Issue
#6243.patch (345 bytes) - added by rehanali 2 years ago.
Added patch

Download all attachments as: .zip

Change History (5)

@aezazshekh
2 years ago

Screenshot of Issue

@rehanali
2 years ago

Added patch

#1 @aezazshekh
2 years ago

  • Keywords has-patch has-screenshots added

#2 @coffee2code
2 years ago

  • Owner set to coffee2code
  • Resolution set to fixed
  • Status changed from new to closed

In 11756:

Photo Directory: Hide .entry-footer for pages when user is not logged in since it'll always be empty and adds excessive padding.

CSS's :empty() would have been more concise, more accurately reflective of intent, and would accommodate future inclusion of content, but it isn't supported by anything at the moment (at least when tag contains any and only whitespace).

As an alternative, the parent theme template-parts/content-page.php could have been copied locally and the footer omitted when empty.

Props aezazshekh, coffee2code.
Fixes #6243.

#3 @coffee2code
2 years ago

@rehanali: Sorry for not including you for props on this commit. I've ensured that you earned the Meta contributor badge as you would have if I had properly included you. Thanks!

Note: See TracTickets for help on using tickets.