Making WordPress.org

Opened 2 years ago

Closed 2 years ago

#6296 closed defect (bug) (fixed)

Navigation: HTML ul element should not contain aria-expanded

Reported by: alexstine's profile alexstine Owned by: dd32's profile dd32
Milestone: Priority: normal
Component: Profiles Keywords:
Cc:

Description

On profiles.wordpress.org and possibly other sites, the ul element has aria-expanded.

<nav id="site-navigation" class="main-navigation" role="navigation">
					<button class="menu-toggle dashicons dashicons-arrow-down-alt2" aria-controls="primary-menu" aria-expanded="false" aria-label="Primary Menu"></button>
					<div id="primary-menu" class="menu">
						<ul class="nav-menu" aria-expanded="false">
													<li class=""><a href="https://login.wordpress.org/register?locale=en_US&amp;redirect_to=https%3A%2F%2Fprofiles.wordpress.org%2Falexstine%2F" rel="nofollow">Register</a></li>
							<li><a href="https://login.wordpress.org/?redirect_to=https%3A%2F%2Fprofiles.wordpress.org%2Falexstine%2F&amp;locale=en_US" rel="nofollow">Log In</a></li>
						
						</ul>
					</div>
				</nav>

The ul element should not have aria-expanded only a trigger button.

Change History (4)

This ticket was mentioned in Slack in #meta by alexstine. View the logs.


2 years ago

#2 @dd32
2 years ago

  • Owner set to dd32
  • Status changed from new to accepted

#3 @dd32
2 years ago

It looks like this was taken care of for the rest of the themes in [7964] via #3927, this copy of that JS file was missed.

#4 @dd32
2 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

Fixed via r18793-dotorg.

Profiles: Remove unnecessary aria attribute.

Props alexstine.
Merges https://meta.trac.wordpress.org/changeset/7964.
Fixes https://meta.trac.wordpress.org/ticket/6296.
Note: See TracTickets for help on using tickets.