Making WordPress.org

Opened 4 years ago

Closed 6 weeks ago

#6301 closed enhancement (worksforme)

Make link in handbook about contribution to core open in a new tab

Reported by: NekoJonez Owned by:
Priority: normal Milestone:
Component: Handbooks Keywords:
Cc:

Description

Today I helped fixing a typo in core and I followed the info in the link: https://make.wordpress.org/core/handbook/contribute/git/github-pull-requests-for-code-review/#in-github

Now, I was surprised that the links of "fork this repo" didn't open in a new tab. It might help new users if it's opened in a new tab so people can still easily go back to the info in the handbook.

Change History (3)

#1 @jeroenrotty
4 years ago

There is an accessibility disadvantage to opening up links in new tabs without the user wanting this.

This ticket was mentioned in Slack in #accessibility by nekojonez. View the logs.


4 years ago

#3 @obenland
6 weeks ago

  • Resolutionworksforme
  • Status newclosed

Thanks for the report! Opening links in new tabs without the user's choice is an accessibility issue (see WCAG 3.2.2 and the docs team's best practices), it disorients assistive-technology users and breaks the back button. Users who prefer a new tab can middle-click or ctrl/cmd+click, while the reverse isn't possible if we force target="_blank".

Note: See TracTickets for help on using tickets.