WordPress.org

Making WordPress.org

Opened 5 years ago

Closed 5 years ago

#631 closed defect (fixed)

Handbook design improvements

Reported by: samuelsidler Owned by:
Milestone: Priority: normal
Component: Developer Hub Keywords:
Cc:

Description

There's a few weird things about the handbook design that we need to improve. Here's a list of what I've found so far.

We can add more to this ticket as we find it.

Change History (7)

#1 @coffee2code
5 years ago

In 892:

Code Reference: Topics box UI improvements:

  • Fix the wrapping of text around the Topics box (prevent main body text from starting below the box)
  • Fix Topics right padding for embedded lists
  • Add some margin-bottom to headings

See #631.
props tjnowell.

#2 @coffee2code
5 years ago

In 893:

Code Reference: fix sidebar bug where active primary page caused all subpages to appear active as well

See #631.
props tjnowell.

#3 @coffee2code
5 years ago

In 894:

Code Reference: improve table styling in handbook content

See #631.
props tjnowell.

#4 @coffee2code
5 years ago

In 899:

Code Reference: improve sidebar wrapping for primary pages. See #631

#5 @coffee2code
5 years ago

In 900:

Code Reference: improve sidebar wrapping for subpages. See #631

#6 @coffee2code
5 years ago

In 922:

Code Reference: make handbook page navigation links abide by menu ordering. See #631

Introduces and uses wporg_developer_post_nav_via_menu() to determine previous/next linking according to ordering defined in a specified menu (which is how Chapters are ordered).

#7 @coffee2code
5 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Regarding the only unaddressed item at this point:

Decide what to do about wrapping in the [php] tag

We discussed this last week during the chat. We're not sure what @samuelsidler (he wasn't present at the time) was suggesting, but if it's what we assumed -- that he meant some sort of line-wrapping for code -- then @DrewAPicture and I are opposed.

The code wraps according to newlines within the code itself. If a line is too long, then horizontal scrolling is employed. This would be our preferred behavior. Introducing soft breaks in long lines of code would be suboptimal to users/developers viewing the code in the handbooks.

Unless we misunderstood?

Since all other issues are resolved, closing the ticket.

Note: See TracTickets for help on using tickets.