Trac: Spacing for header navigation sub-menu arrow icons

[sabernhardt]

On Trac, the dropdown icons for sub-menus are inside the <a> element, but other WordPress sites add the icon span after <a>. Because the links have padding, Trac does not give any space before the icon.

On ​#WP55874, @praful2111 shared a ​screenshot and gave a possible solution:

.core .wp-block-group.global-header .global-header__navigation .wp-block-navigation__container .wp-block-navigation-item.has-child a > span.wp-block-navigation__submenu-icon {
    width: 22px;
}

[sabernhardt]

Instead of setting the width, I think the adjacent sibling selector could help in this situation:

@media (min-width:890px) {
	.wp-block-group.global-header .global-header__navigation .wp-block-navigation-item__label + .wp-block-navigation__submenu-icon {
		padding-left: 6px;
		padding-right: 16px;
	}
}

[dd32]

This sounds like the Trac templates haven't been updated to reflect a change made in the global header.

I'll update the templates, let's see if that fixes this.

[dd32]

In 11900:

Trac: Update global headers template.

See #6336.

[praful2111]

@sabernhardt @dd32 Is this type of issue are consider in meta contribution ?

[dd32]

It looks like r11900 has worked, it's still propagating to meta.trac though.

@praful2111 Yes, apologies, I should've prop'd you both in the above commit. I'll do that now and grant you the badge! (edit: Done! You'll see the above commit referenced on your profile & the meta-contributor badge)