Making WordPress.org

Opened 21 months ago

Closed 21 months ago

Last modified 21 months ago

#6336 closed defect (bug) (fixed)

Trac: Spacing for header navigation sub-menu arrow icons

Reported by: sabernhardt's profile sabernhardt Owned by: dd32's profile dd32
Milestone: Priority: normal
Component: Trac Keywords:
Cc:

Description

On Trac, the dropdown icons for sub-menus are inside the <a> element, but other WordPress sites add the icon span after <a>. Because the links have padding, Trac does not give any space before the icon.

On #WP55874, @praful2111 shared a screenshot and gave a possible solution:

.core .wp-block-group.global-header .global-header__navigation .wp-block-navigation__container .wp-block-navigation-item.has-child a > span.wp-block-navigation__submenu-icon {
    width: 22px;
}

Change History (5)

#1 @sabernhardt
21 months ago

Instead of setting the width, I think the adjacent sibling selector could help in this situation:

@media (min-width:890px) {
	.wp-block-group.global-header .global-header__navigation .wp-block-navigation-item__label + .wp-block-navigation__submenu-icon {
		padding-left: 6px;
		padding-right: 16px;
	}
}

#2 @dd32
21 months ago

  • Owner set to dd32
  • Status changed from new to accepted

This sounds like the Trac templates haven't been updated to reflect a change made in the global header.

I'll update the templates, let's see if that fixes this.

#3 @dd32
21 months ago

In 11900:

Trac: Update global headers template.

See #6336.

#4 @praful2111
21 months ago

@sabernhardt @dd32 Is this type of issue are consider in meta contribution ?

#5 @dd32
21 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

It looks like r11900 has worked, it's still propagating to meta.trac though.

@praful2111 Yes, apologies, I should've prop'd you both in the above commit. I'll do that now and grant you the badge! (edit: Done! You'll see the above commit referenced on your profile & the meta-contributor badge)

Last edited 21 months ago by dd32 (previous) (diff)
Note: See TracTickets for help on using tickets.