Making WordPress.org

#6364 closed enhancement (fixed)

Optimize the syntax for judging whether to add "-" when preparing parameters in the SVN tool in the plugin directory

Reported by: sunxiyuan's profile sunxiyuan Owned by: dd32's profile dd32
Milestone: Plugin Directory v3.0 Priority: lowest
Component: Plugin Directory Keywords: has-patch
Cc:

Description (last modified by dd32)

'-' != substr( $key, 0, 1 )

to

!str_starts_with( $key, '-' )

Change History (3)

This ticket was mentioned in PR #74 on WordPress/wordpress.org by sunxiyuan.


22 months ago
#1

Optimize the syntax for judging whether to add "-" when preparing parameters in the SVN tool in the plugin directory

https://meta.trac.wordpress.org/ticket/6364

#2 @dd32
22 months ago

  • Description modified (diff)
  • Priority changed from normal to lowest

Fixed description, it was the inverse of what you intended on saying :)

There's nothing wrong with the existing code, and any micro-optimizations here aren't going to make any form of impact.

That being said, I'll commit this, so we don't have the PR/ticket left open.

#3 @dd32
22 months ago

  • Owner set to dd32
  • Resolution set to fixed
  • Status changed from new to closed

In 11918:

Plugin Directory: Switch to using str_starts_with() in the SVN class.

Props sunxiyuan.
Closes https://github.com/WordPress/wordpress.org/pull/74.
Fixes #6364.

Note: See TracTickets for help on using tickets.