Opened 2 years ago

Last modified 4 weeks ago

#6380 new enhancement

Prevent use of 'trunk' as a Stable Version

Reported by: ipstenu's profile Ipstenu Owned by:
Milestone: Priority: normal
Component: Plugin Directory Keywords:


In order to make rollbacks more stable, and reduce friction with users, the time has come.... to chop down trunk.

Currently if you use Stable tag: trunk in your readme, it will pull the files from trunk. And that's great, but it can cause issues with figuring out what the rollback should be.

It shouldn't be bad with our proposed changes, but it does mean that when we want to expand and say "rollback 2 versions" (or even to a specific version), if everything's always in trunk and never tags... can't download the old version :(

Trunk as 'stable' is meeting the end of it's life.

The 'best' path might be to check the readme.txt for a stable tag value and, if it's trunk, error back "Stable Tag cannot be trunk. It must match the Version as indicated in your plugin headers." Bonus, make sure we only check for the FIRST iteration (some people re-used Stable Tag per version in their changelogs).

Change History (3)

This ticket was mentioned in Slack in #meta by ipstenu. View the logs.

18 months ago

#2 @dd32
13 months ago

In 12614:

Plugin Directory: Readme Validator: Don't encourage the use of Stable Tag: trunk for plugins.

Props Ipstenu.
Fixes #6987.
See #6380.

#3 @dd32
4 weeks ago

In 13726:

Plugin Directory: Import: When importing from SVN, if the plugin specifies a Stable Tag that does not exist, and we fall back to trunk, warn them.

See #6380, #6108.
Fixes #5645.

Note: See TracTickets for help on using tickets.