Making WordPress.org

Opened 18 months ago

Closed 18 months ago

Last modified 7 weeks ago

#6551 closed defect (bug) (fixed)

Plugin Directory: Prepare for Jetpack update

Reported by: kraftbj's profile kraftbj Owned by: dd32's profile dd32
Milestone: Priority: high
Component: Plugin Directory Keywords: has-patch
Cc:

Description

Jetpack moved the location of the Search files which are hardcoded into the Plugin Directory.

The PR located at https://github.com/WordPress/wordpress.org/pull/103 allows for both the legacy and modern file locations to be used.

This does throw a warning for include_once failing. If that's not acceptable, I can put some more checks in place first. This is intended to be temporary with a follow PR coming once Jetpack has been updated.

The Jetpack update is being requested to add a feature for an upcoming Developer page, but this is blocking the update.

To test:
Apply this patch and update the svn external for Jetpack to tag 11.3.
Visit https://wordpress.org/plugins/ — both before and after, the page should load and search works.

cc: @dd32

Change History (12)

#1 @bph
18 months ago

The issue regarding the developer blog is: when located in the Footer of the block theme, the submission form space doesn't get focus back to display the confirmation and other messages. To see them, the user would scroll all the way down to the footer again.

This ticket was mentioned in PR #103 on WordPress/wordpress.org by @kraftbj.


18 months ago
#2

Jetpack moved the Search code from a module to a package. This allows either to be loaded to prepare for a Jetpack update on w.org.

A follow-up will come once it has been updated to only leave the new location.

https://meta.trac.wordpress.org/ticket/6551

#3 @dd32
18 months ago

  • Owner set to dd32
  • Status changed from new to accepted

#4 @dd32
18 months ago

In 12158:

Plugin Directory: Search: Prepare for a Jetpack upgrade.

Jetpack moved where the search files are stored, causing the existing code here to not work as expected.

Props kraftbj, dd32.
Closes https://github.com/WordPress/wordpress.org/pull/103.
See #6551.

#5 @dd32
18 months ago

@kraftbj Thank you!

I've altered the patch to avoid the PHP warnings, and assume newer jetpack.
The Jetpack Autoloader appears to exist in the version we were running already, so that made the changes a little simpler.

Leaving this ticket open to track further changes needed.

#6 @dd32
18 months ago

In 12159:

Theme Directory: Cease including the Jetpack SEO files manually.

See #6551.

#7 @dd32
18 months ago

I'm not sure if the above broke the Jetpack SEO integration for the Theme Directory, added in [7299], as I'm not 100% sure what differences it makes is.

Pattern Directory also needed a change, as this was fataling: https://github.com/WordPress/pattern-directory/commit/b8393b3927588b16df1d340327d2ae6efe2843ac

#8 @dd32
18 months ago

In 12160:

Theme Directory: Force-enable the SEO jetpack module, instead of directly including the Jetpack files.

See #6551.

#9 @dd32
18 months ago

WordPress.org is running Jetpack 11.4 now.

Plugin search appears to be working fine.

I'm going to leave the code in [12158] in place for a bit, just so we can revert Jetpack on sandboxes if we need to debug any search changes. Reverting to Jetpack 10.2 in production is not really an option now due to the above changes to Pattern & Theme directories.

This ticket was mentioned in Slack in #meta by tellyworth. View the logs.


18 months ago

#11 @kraftbj
18 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

Thanks all. Closing this as Jetpack's updates are unblocked and working.

walak19573 commented on PR #103:


7 weeks ago
#12

i am facing how to do it guide more about it

Note: See TracTickets for help on using tickets.