Update link in grey section box in themes directory

[sabernhardt]

@dansoschin opened this in ​#core54542

1. Start here: ​https://wordpress.org/themes/
2. Click the link in the grey area midpage for Commercial Themes and you end up at this page: ​https://wordpress.org/themes/commercial/ as expected.

On this page: ​https://wordpress.org/themes/commercial/, however, the link in the grey section does not change... it remains the same link (now to itself, making it redundant and perhaps a little confusing.)

I would expect that the link in the grey section would change from linking to the commercial directory to linking back to the main themes directory ( ​https://wordpress.org/themes/.)

In other words, change the link in the grey area so that you have easy navigation back to where you came from, thus enabling you to basically toggle between public and commercial themes.

When you are in the public themes directory, the link goes to commercial themes. When you are in the commercial themes directory, the links should go to public but current does not.

[dd32]

Just noting that this is a relatively recent change (adding the menu there), and likely to change as part of an upcoming redesign.

The standard way "back" is via clicking the Themes header, or the browser back button I guess.

I can see how it looks like a toggle between free and commercial though, but it's intended to be the "subpages" menu list.

[coffee2code]

As Dion explained, the "Commercial Themes" link is displayed in a menubar and links to a page. Menubar links don't usually function as toggles. The confusion is no doubt due to one or more of a few unfortunately design aspects:

• There is only one link in the menubar
• Most other WordPress.org sites with a menubar have it integrated into the blue header bar when not the front page (the Plugin Directory, for example)
• The gray background likely doesn't provide any cues that it is a menubar (elsewhere, in the same header location, the Make sites use a similar gray as the background for the welcome box)
• The link doesn't change to provide any indication that you're on the page being linked

While all four could be changed in the current theme, the first three require a few design decisions which will undoubtedly be part of the discussion for the redesign of the site and perhaps not worth the effort in the current design.

I can make the link show an underline when you're on the page being linked to, which is consistent with the behavior of menubar links for other WordPress.org sites. So this will be partially addressed via the imminent commit, but any design change related to this is a wontfix since a theme redesign will eventually happen.

[coffee2code]

In 13048:

Theme Directory: Improve appearance of menubar link.

Improves hover design and adds current page recognition and design. Not perfect, but good enough for the one link it needs to handle.

Props sabernhardt, coffee2code.
See #6552.