Making WordPress.org

Opened 2 years ago

Closed 5 months ago

#6586 closed defect (bug) (worksforme)

Remove multiple complementary landmarks from widgets

Reported by: alexstine's profile alexstine Owned by:
Milestone: Priority: normal
Component: Handbooks Keywords:
Cc:

Description

On a developer handbook page, there are multiple complementary landmarks injected by widgets.

Example page: https://developer.wordpress.org/block-editor/

Problem code:

<div id="secondary" class="widget-area" role="complementary">
		<div id="secondary-content">
				<aside id="search-7" class="widget widget_search">
				</aside>
				<aside id="handbook_pages-3" class="widget widget_wporg_handbook_pages">
				</aside>
		</div>
</div>

Solution: Since there is already a wrapping ARIA role, remove the aside tags and replace them with divs or another HTML element. Aside tag is HTML5 and produces a complementary landmark when used.

Change History (2)

#1 @coffee2code
5 months ago

Thanks for the report, @alexstine! The DevHub theme has been replaced since this ticket was filed. Do you consider this to still be an issue? There is currently only one aside on the page, for the left sidebar listing of handbook pages.

#2 @alexstine
5 months ago

  • Resolution set to worksforme
  • Status changed from new to closed

@coffee2code I was trying to figure out what this was about, crazy, opened this almost 2 years ago. You seem to be correct, no double aside anymore so good to close. Thanks.

Note: See TracTickets for help on using tickets.