Making WordPress.org

Opened 17 months ago

Closed 17 months ago

Last modified 17 months ago

#6592 closed defect (bug) (fixed)

Editor styles of code block are broke. Text is not legible

Reported by: fabiankaegy's profile fabiankaegy Owned by: dd32's profile dd32
Milestone: Priority: normal
Component: Make (Get Involved) / P2 Keywords: has-patch
Cc:

Description

This is a result of r12278

The Code block in the editor has a light text color (and obviously doesn’t get the syntax highlighting)

The color is coming from wp-content/plugins/code-syntax-block/assets/blocks.editor.css line 27
But probably needs to get overwritten in the theme styles.

My suggestion would be adding a color definition here:

https://github.com/fabiankaegy/wordpress.org/blob/b7627a4da9b47d8a2a1e2d6025013d335eaaef53/wordpress.org/public_html/wp-content/themes/pub/wporg-breathe/style.css#L536
It will always get overwritten on the frontend with the syntax highlighting.

Change History (5)

This ticket was mentioned in PR #110 on WordPress/wordpress.org by @fabiankaegy.


17 months ago
#1

  • Keywords has-patch added

This ticket was mentioned in Slack in #meta by fabiankaegy. View the logs.


17 months ago

#3 @dd32
17 months ago

  • Component changed from General to Make (Get Involved) / P2

#4 @dd32
17 months ago

  • Owner set to dd32
  • Resolution set to fixed
  • Status changed from new to closed

In 12282:

Make Sites: Make code blocks readable within the wp-admin editor.

Props fabiankaegy, dd32.
Closes https://github.com/WordPress/wordpress.org/pull/110
Fixes #6592.

#5 @dd32
17 months ago

I ended up removing the background style instead of adding the color styles, as this way it just inherits the plugins colours on both the front-end and backend.

The background colour was added due to this kind of issue in #5489, so I think removing it makes more sense.

Note: See TracTickets for help on using tickets.