Support icons/banners by language - 2

[ghera74]

Thanks to @dd32 for pointing me to #3935 form the ticket #6625.

Actually, that solution seems to work only with screenshots, not with icons and banners.

This is the plugin I'm working on:
​https://wordpress.org/plugins/wc-exporter-for-reviso/

Here is the assets folder:
​http://plugins.svn.wordpress.org/wc-exporter-for-reviso/assets/

And this is the result:
​https://it.wordpress.org/plugins/wc-exporter-for-reviso/

The screenshot-1-it_IT.png is used correctly but all the other localized images are ignored.

I know that adding text in images is never a good idea, but the reason for having a different image here is basically the logo in the top right corner: Reviso is a software that changes the name in Italy in Contabilità in Cloud.

Thanks.

[dd32]

Thanks for testing it @ghera74, I can see that the assets were all stored without a locale in the plugin directory metadata, I'll see about what is happening there.

[dd32]

@ghera74 Apologies for the delay on this, it fell by the wayside, and I failed to update with the findings.

It appears that while we added support for importing of the localised icons/banners, we don't actually display them at present.

I'm going to file a PR for that today.

Thanks for your patience.

[dd32]

In 12474:

Plugin Directory: Use Localised images for banners if available.

See #6627, #3935.

[dd32]

In 12475:

Plugin Directory: Ensure that the 'svg' key returned is a URL rather than an object of SVG details.

This inadvertantly returned an object for some plugins, which when parsed by WordPress causes fatal errors.

See [12474].
See #6627.

[ghera74]

Replying to dd32:

@ghera74 Apologies for the delay on this, it fell by the wayside, and I failed to update with the findings.

It appears that while we added support for importing of the localised icons/banners, we don't actually display them at present.

I'm going to file a PR for that today.

Thanks for your patience.

No problem at all and thanks for your work @dd32.

[dd32]

In 12477:

Plugin Directory: When a plugin has multiple formats of an image asset (svg, png, jpg) prefer them in that order.

See ​https://wordpress.slack.com/archives/C02QB8GMM/p1678987204746449.
See #6627.

[dd32]

I don't think there's anything left here, re-open if there's anything missed.