Making WordPress.org

Opened 17 months ago

Closed 3 weeks ago

#6627 closed defect (bug) (fixed)

Support icons/banners by language - 2

Reported by: ghera74's profile ghera74 Owned by: dd32's profile dd32
Milestone: Priority: normal
Component: Plugin Directory Keywords: reporter-feedback
Cc:

Description

Thanks to @dd32 for pointing me to #3935 form the ticket #6625.

Actually, that solution seems to work only with screenshots, not with icons and banners.

This is the plugin I'm working on:
https://wordpress.org/plugins/wc-exporter-for-reviso/

Here is the assets folder:
http://plugins.svn.wordpress.org/wc-exporter-for-reviso/assets/

And this is the result:
https://it.wordpress.org/plugins/wc-exporter-for-reviso/

The screenshot-1-it_IT.png is used correctly but all the other localized images are ignored.

I know that adding text in images is never a good idea, but the reason for having a different image here is basically the logo in the top right corner: Reviso is a software that changes the name in Italy in Contabilità in Cloud.

Thanks.

Change History (7)

#1 @dd32
17 months ago

  • Owner set to dd32
  • Status changed from new to accepted

Thanks for testing it @ghera74, I can see that the assets were all stored without a locale in the plugin directory metadata, I'll see about what is happening there.

#2 follow-up: @dd32
14 months ago

@ghera74 Apologies for the delay on this, it fell by the wayside, and I failed to update with the findings.

It appears that while we added support for importing of the localised icons/banners, we don't actually display them at present.

I'm going to file a PR for that today.

Thanks for your patience.

#3 @dd32
14 months ago

In 12474:

Plugin Directory: Use Localised images for banners if available.

See #6627, #3935.

#4 @dd32
14 months ago

In 12475:

Plugin Directory: Ensure that the 'svg' key returned is a URL rather than an object of SVG details.

This inadvertantly returned an object for some plugins, which when parsed by WordPress causes fatal errors.

See [12474].
See #6627.

#5 in reply to: ↑ 2 @ghera74
14 months ago

Replying to dd32:

@ghera74 Apologies for the delay on this, it fell by the wayside, and I failed to update with the findings.

It appears that while we added support for importing of the localised icons/banners, we don't actually display them at present.

I'm going to file a PR for that today.

Thanks for your patience.

No problem at all and thanks for your work @dd32.

#6 @dd32
14 months ago

In 12477:

Plugin Directory: When a plugin has multiple formats of an image asset (svg, png, jpg) prefer them in that order.

See https://wordpress.slack.com/archives/C02QB8GMM/p1678987204746449.
See #6627.

#7 @dd32
3 weeks ago

  • Resolution set to fixed
  • Status changed from accepted to closed

I don't think there's anything left here, re-open if there's anything missed.

Note: See TracTickets for help on using tickets.