Don't enqueue zxcvbn.min.js when not needed

[jonoaldersonwp]

Plugin and theme pages load /wp-includes/js/zxcvbn.min.js (via zxcvbn-async), which is nearly 400kb(!).

It seems that this is a password strength-o-meter, which almost certainly isn't used on the front end on these pages/templates.

Can this be dequeued/removed?

[dd32]

This has been resolved via ​https://github.com/WordPress/wporg-two-factor/issues/35

[jonoaldersonwp]

Super! :)

[adamwood]

After changing the script enqueueing from 'script' to 'viewScript' in ​https://github.com/WordPress/wporg-two-factor/issues/35, the dependencies are no longer loaded at all, resulting in a JS crash on the 2FA TOTP screen at ​https://wordpress.org/support/users/{username}/edit/account/?screen=totp

[dd32]

I've submitted a Gutenberg PR which resolves this: ​https://github.com/WordPress/gutenberg/pull/48268

In the meantime, Adding this code appears to work around it:

remove_filter( 'block_type_metadata', 'gutenberg_block_type_metadata_multiple_view_scripts' );
remove_filter( 'block_type_metadata_settings', 'gutenberg_block_type_metadata_view_script', 10, 2 );

As we're running WordPress 6.1, the viewScript functionality should be provided by core, so these filters shouldn't technically be needed, but I'm not 100% sure..

[paulkevan]

I deployed the code above since users were unable to setup TOTP.

[dd32]

re-closing this.

Another change was required to fix another breakage from the fix in ​https://github.com/WordPress/wporg-two-factor/pull/66, and I've left ​https://github.com/WordPress/wporg-two-factor/pull/65 open to revert it all (and cause these JS libraries to always be loaded) if another breakage is encountered, until Gutenberg fixes it.