Making WordPress.org

Opened 15 months ago

Closed 15 months ago

Last modified 15 months ago

#6788 closed defect (bug) (worksforme)

Rejecting fuzzy strings can apporve translations

Reported by: timse201's profile timse201 Owned by:
Milestone: Priority: normal
Component: Translate Site & Plugins Keywords: close
Cc:

Description

When rejecting strings that are marked fuzzy, they will be synced as approved in corresponding project.
eg. if you reject a string in stable, it will be approved in dev.

Change History (7)

#1 @vladytimy
15 months ago

Thank you for the ticket!
I can reproduce it.

@spiraltee do you think it's related to this changeset ?

#2 @wavytee
15 months ago

@vladytimy Thanks for the ping, it probably is but please let me take a look.

Version 0, edited 15 months ago by wavytee (next)

#3 @spiraltee
15 months ago

@vladytimy Thanks for the ping, it probably is but please let me take a look. Earlier comment was from my test account.

This ticket was mentioned in Slack in #polyglots by vladytimy. View the logs.


15 months ago

This ticket was mentioned in PR #126 on WordPress/wordpress.org by trymebytes.


15 months ago
#5

  • Keywords has-patch added

Trac ticket: https://meta.trac.wordpress.org/ticket/6788

When a fuzzy translation is rejected in one project(e.g dev) it appears in the other project(e.g stable) as current.

This PR fixes the issue and ensure that statuses are constant across projects even if the translation had been existing on either dev or stable.

To test, set a translation to fuzzy on dev(or stable), then reject that fuzzy translation on stable or (dev), the translation should appear as rejected on both dev and stable.

#6 @vladytimy
15 months ago

  • Keywords close added; has-patch removed
  • Resolution set to worksforme
  • Status changed from new to closed

Fixed in https://meta.trac.wordpress.org/changeset/12432
Thank you @spiraltee

This ticket was mentioned in Slack in #polyglots by spiraltee. View the logs.


15 months ago

Note: See TracTickets for help on using tickets.