Making WordPress.org

Opened 7 months ago

Closed 4 weeks ago

#6812 closed defect (bug) (fixed)

Content overflow issue on search form

Reported by: baroliyamayur's profile baroliyamayur Owned by: coffee2code's profile coffee2code
Milestone: Priority: normal
Component: Plugin Directory Keywords: needs-patch has-screenshots
Cc:

Description

Content overflow issue on search form.

Page URL:- https://wordpress.org/plugins/

Issue Screenshot:- https://share.cleanshot.com/h00rQ4497XTDDz14v2ry

Attachments (1)

6812.patch (326.9 KB) - added by baroliyamayur 7 months ago.
Content overflow issue on search form

Download all attachments as: .zip

Change History (3)

@baroliyamayur
7 months ago

Content overflow issue on search form

#1 @coffee2code
4 weeks ago

@baroliyamayur: Thanks for the report and the patch!

Your patch (here and under other tickets) includes the accumulated changes you've made to WordPress.org code for a number of different tickets (there's stuff in there for the Theme Directory, BuddyPress, Photo Directory, etc). And while it looks like you have the compiled wporg-plugins/css/style.css change that reflects your fix for this, you didn't include the .sass source file for that change, wporg-plugins/client/components/_search-form.scss.

I recommend two things for your patches going forward:

  1. Check to ensure you're only including the necessary changes and changed files necessary to fix the issue in the ticket.
  2. There's no need to include compiled files (.css or .js) that are generated as the result of a build process. Whoever commits the change will run the build process themselves since there will likely have been other changes in the meantime, and to ensure no other changes were snuck into the compiled files. Including the compiled files also makes the diff look much bigger than it is and harder to identify the true changes.

No worries about this ticket though, as I'm about to commit the fix.

#2 @coffee2code
4 weeks ago

  • Owner set to coffee2code
  • Resolution set to fixed
  • Status changed from new to closed

In 12872:

Plugin Directory: Prevent excessively long search input text from flowing over search button.

Props baroliyamayur, coffee2code.
Fixes #6812.

Note: See TracTickets for help on using tickets.