Making WordPress.org

#6819 closed defect (bug) (fixed)

plugin/tags/faq shouldn't redirect to /plugins/#faq

Reported by: tobifjellner's profile tobifjellner Owned by: paulkevan's profile paulkevan
Milestone: Priority: normal
Component: Plugin Directory Keywords: has-patch
Cc:

Description

In the plugin https://wordpress.org/plugins/faq-block/ it's currently impossible to look at other plugins tagged "faq", since https://wordpress.org/plugins/tags/faq/ automatically redirects to https://wordpress.org/plugins/#faq

Change History (7)

#1 @paulkevan
14 months ago

Looks like this is triggering some legacy redirect code: https://github.com/WordPress/wordpress.org/blob/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-plugin-directory.php#L527-L528, which could probably be tightened up so as to not catch the example above, and probably any /tag/ URLs, since the redirect also triggers for any of those other strings like: https://wordpress.org/plugins/tags/stats/

#2 @paulkevan
14 months ago

Seems like the rewrite rules could change to incorporate a more expected URL like:

add_rewrite_rule( '^extend/plugins/([^/]+)/(installation|faq|screenshots|changelog|stats|developers|other_notes)/?$

found the old URLs in: https://web.archive.org/web/20120930114546/http://wordpress.org/extend/plugins/wp-super-cache/

This ticket was mentioned in PR #127 on WordPress/wordpress.org by pkevan.


14 months ago
#3

  • Keywords has-patch added

Avoids too many redirect for URLs containing more common strings (faq,stats).

See: https://meta.trac.wordpress.org/ticket/6819

@johnbillion commented on PR #127:


14 months ago
#4

This might have just broken something: https://meta.trac.wordpress.org/ticket/6824

#5 @paulkevan
14 months ago

  • Owner set to paulkevan
  • Status changed from new to assigned

#7 @paulkevan
14 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

Seems to be fixed, so closing. Thanks for the report @tobifjellner.

Note: See TracTickets for help on using tickets.