WordPress.org

Making WordPress.org

Opened 5 years ago

Closed 4 years ago

#694 closed defect (worksforme)

slackbot should only post mentions once a day

Reported by: SergeyBiryukov Owned by: nacin
Milestone: Priority: normal
Component: Slack & IRC Keywords:
Cc:

Description

ircbot only posted comments to Trac tickets once a day.

Looks like slackbot does not have the same restriction, which results in duplicate comments (see the screenshot).

Attachments (1)

meta-694.png (24.3 KB) - added by SergeyBiryukov 5 years ago.

Download all attachments as: .zip

Change History (9)

#1 @atimmer
5 years ago

A smarter restriction could be better, when a ticket is mentioned it could start a timer for like 15 minutes and reset every time it is mentioned again. Then it will report all disconnected occurrences.

Just an idea.

#2 @Otto42
5 years ago

#744 was marked as a duplicate.

#3 follow-up: @Clorith
5 years ago

There seems to be a slight bug here that makes the slack mentions get pushed in twice as well (so it's mentioned once, but it gets two "mention" entries in trac)

This ticket was mentioned in Slack in #meta by clorith. View the logs.


5 years ago

#5 in reply to: ↑ 3 @SergeyBiryukov
5 years ago

Replying to Clorith:

There seems to be a slight bug here that makes the slack mentions get pushed in twice as well (so it's mentioned once, but it gets two "mention" entries in trac)

I think the second mention comes from Slack itself displaying the ticket summary.

#6 follow-up: @nacin
5 years ago

  • Component changed from Trac to Slack
  • Owner set to nacin
  • Status changed from new to accepted

I've never seen a second mention, and the bot is smart enough to avoid cross-posting the ticket summary. It *could* have happened due to a misconfiguration on our part (such as two outgoing webhooks watching the same Slack channel). If you ever see it again, then please open a new ticket as a bug.

I have throttling code for this done, but I wasn't able to debug why it wasn't working properly. I'll look into it.

#7 in reply to: ↑ 6 @SergeyBiryukov
5 years ago

Replying to nacin:

I've never seen a second mention, and the bot is smart enough to avoid cross-posting the ticket summary. It *could* have happened due to a misconfiguration on our part (such as two outgoing webhooks watching the same Slack channel). If you ever see it again, then please open a new ticket as a bug.

Just noticed a duplicate summary in #forums, see #831.

#8 @ocean90
4 years ago

  • Resolution set to worksforme
  • Status changed from accepted to closed
Note: See TracTickets for help on using tickets.