Opened 17 months ago
Closed 17 months ago
#7036 closed enhancement (fixed)
Theme Directory: Add filters for community & commercial themes
Reported by: | ryelle | Owned by: | ryelle |
---|---|---|---|
Milestone: | Priority: | normal | |
Component: | Theme Directory | Keywords: | has-patch |
Cc: |
Description
The ability to categorize a theme as "community" or "commercial" was launched at the end of last year, and many themes have opted into these. The category shows up on individual themes, but there currently isn't a way to filter by this.
The attached design should be used, adding navigation links to filter the current view to just the selected category.
(this is a similar ticket to #7035, but for the Theme Directory)
Attachments (2)
Change History (21)
This ticket was mentioned in PR #149 on WordPress/wordpress.org by @ryelle.
17 months ago
#1
- Keywords has-patch added
@dufresnesteven commented on PR #149:
17 months ago
#2
Can we move the margin to the padding declaration to increase the indicator width?
https://github.com/WordPress/wordpress.org/blob/ab81d3e771247cdb7d8f83bf33697f6c4d3921cd/wordpress.org/public_html/wp-content/themes/pub/wporg-themes/css/components/_main.scss#L1446
https://github.com/WordPress/wordpress.org/blob/ab81d3e771247cdb7d8f83bf33697f6c4d3921cd/wordpress.org/public_html/wp-content/themes/pub/wporg-themes/css/components/_main.scss#L1447
Before | After |
---|---|
@dufresnesteven commented on PR #149:
17 months ago
#3
17 months ago
#4
Is it possible my patch didn't apply correctly?
@StevenDufresne Make sure you have the API sandboxed, but there's also caching which you may have run into.
If you look for if ( 'local' === wp_get_environment_type() ) {
in wporg-themes/functions.php and force-enable that branch it should bypass caching.
17 months ago
#5
I'm personally not a fan of replacing the Latest
and Popular
filters with the dropdown and treating it like a Sort - Because they're not sorts, they're views.
If we want to convert them to sorts instead, then that requires changing them from browse
to being orderby
s in the query handlings.
jasmussen commented on PR #149:
17 months ago
#6
Ideally the filter bar could visually be similar to that of the pattern and plugin directory "tab-bars", i.e. just a blue background on the active state. The theme directory here is a bit the odd one out, with a bordered box, white background, and bottom border.
But given these extend sections are all due for a more coherent visual refresh in the future, this is more of a future concern, where I would expect filter-bars across to be unified, and lean closer to the pattern the plugin and pattern directories use. So on these, I'll defer to you on the dev side to choose. Functionally, this looks right. Thank you!
17 months ago
#7
I'm personally not a fan of replacing the Latest and Popular filters with the dropdown and treating it like a Sort - Because they're not sorts, they're views. (The code calls it a 'sorter' but that's a misnomer, and relates to the original code that was pulled from wp-admin theme browser)
Yeah, I was halfway to updating that (sorter term) when I realized it was a bigger change, and I was aiming for the smallest change to ship the new filters. (that's the same reason I didn't adjust the active state look, @jasmussen)
Instead of the dropdown implying sort, we could keep the tab look, which would clear up that confusion:
What do you think, @jasmussen ?
17 months ago
#8
I updated the spacing on links, which also fixes the slightly awkward focus state 👍🏻
Before | After |
---|---|
Is it possible my patch didn't apply correctly? It seems to load the relevant view on page load but clicking the menu items returns empty from the endpoint?
The PR has changes to both /themes/pub/wporg-themes/
and /plugins/theme-directory/
— I'm not sure how you apply patches but I need to sync those separately, and if you miss the plugin, the endpoint doesn't work.
jasmussen commented on PR #149:
17 months ago
#9
Thanks for the clarity. The tabbed approach seems like the most pragmatic approach. I personally think that can be okay to go with, so for speed that seems fine to me.
I would love a general sanity check by @richtabor and @fcoveram, probably doesn't need to block anything here, mostly for followup.
#13
@
17 months ago
@ryelle
There used to be a number of themes while browsing popular or block themes. But now, I can't see how many block themes there are. It is removed. Can we have that back or it is removed intentionally?
This ticket was mentioned in Slack in #themereview by kafleg. View the logs.
17 months ago
#16
@
17 months ago
- Resolution fixed deleted
- Status changed from closed to reopened
There used to be a number of themes while browsing popular or block themes. But now, I can't see how many block themes there are. It is removed. Can we have that back or it is removed intentionally?
This was removed intentionally, for now, but the count will be back when the theme directory is redesigned.
the theme search is missing
You're right, the search should have been moved into the header like the Plugin Directory.
See https://github.com/WordPress/wordpress.org/pull/142 for the Plugin Directory version of this PR.
This updates the navigation on the Theme Directory to add "Commercial" and "Community" links, which show archives of themes using that categorization. It creates new "browse" pages,
wordpress.org/themes/browse/commercial/
andwordpress.org/themes/browse/community/
.⚠️ Due to the way the theme's JS routing works, I can't figure out a great way to combine filters (ex, we can't sort "Community" by popular, nor can we filter out "Community" + "Block Themes"). But this matches the current behavior anyway - you can't sort Block Themes by popular, either.
This is built on #148 but I can't seem to chain them since that branch lives on my own fork, but I intended for them to be separate commits.
cc @WordPress/meta-design
Screenshots:
I also added some responsive styles so the nav isn't so awkward on smaller screens. it's not great, but should be fine until this is redesigned.