Making WordPress.org

Opened 11 months ago

Closed 10 months ago

Last modified 10 months ago

#7047 closed defect (bug) (fixed)

Fix homepage og image

Reported by: jonoaldersonwp's profile jonoaldersonwp Owned by: paulkevan's profile paulkevan
Milestone: Priority: high
Component: General Keywords: has-patch
Cc:

Description

The og image tag on the wordpress.org homepage seems to be pulling in a thumbnail from YouTube.*

This should be corrected to https://s.w.org/images/home/screen-themes.png?3 (consistent with Rosetta sites).

*prior to a fix yesterday, this was a banner promoting matt's 2022 site talk. This was corrected at wordcamp, but there's seemingly something weird thing on here!

Attachments (1)

wordpress-homepage-ogimage.png (268.3 KB) - added by joostdevalk 10 months ago.
Improved image

Download all attachments as: .zip

Change History (12)

This ticket was mentioned in Slack in #meta by jonoaldersonwp. View the logs.


11 months ago

This ticket was mentioned in Slack in #meta by joostdevalk. View the logs.


10 months ago

#3 @paulkevan
10 months ago

So I tracked this down to a filter being used too late, and therefore being overridden on output. What it should be is here: https://github.com/WordPress/wporg-main-2022/blob/trunk/source/wp-content/themes/wporg-main-2022/inc/page-meta-descriptions.php#L44

Setting it to run at priority 11 here: https://github.com/WordPress/wporg-main-2022/blob/trunk/source/wp-content/themes/wporg-main-2022/inc/page-meta-descriptions.php#L69 would allow the customizations to happen. Is it intentional to have a screenshot of the theme dashboard on the Rosetta sites?

@joostdevalk
10 months ago

Improved image

#4 @joostdevalk
10 months ago

Actually, what it should be we should also update, as marketing made a better image. Attached above. I think it should be that image on _all_ sites, including the Rosetta sites, and I think you're fine running that filter at priority "whatever's needed" :D

#5 @paulkevan
10 months ago

  • Owner set to paulkevan
  • Status changed from new to assigned

Made the image available on https://s.w.org/images/home/wordpress-homepage-ogimage.png, will update once the references have been updated on wp.org and Rosetta sites.

This ticket was mentioned in Slack in #meta by courtneyengle. View the logs.


10 months ago

This ticket was mentioned in PR #270 on WordPress/wporg-main-2022 by pkevan.


10 months ago
#7

  • Keywords has-patch added

Adds new OG image, and overrides meta tags by running later.

Fixes https://meta.trac.wordpress.org/ticket/7047 for WP.org. Rosetta sites will be done in that repo.

Props @jonoaldersonwp, @joostdevalk, @pkevan

This ticket was mentioned in PR #157 on WordPress/wordpress.org by pkevan.


10 months ago
#8

Adds new OG image.

Fixes https://meta.trac.wordpress.org/ticket/7047.

Props @jonoaldersonwp, @joostdevalk, @pkevan

pkevan commented on PR #157:


10 months ago
#9

Committed in e66382c1cbb4ad05d6f708663d82809d3d3e8a5d closing.

#10 @paulkevan
10 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

This ticket was mentioned in Slack in #meta by courtneyengle. View the logs.


10 months ago

Note: See TracTickets for help on using tickets.