Making WordPress.org

Opened 12 months ago

Last modified 11 months ago

#7111 new feature request

Checkbox in translation editor panel

Reported by: marc4's profile Marc4 Owned by:
Milestone: Priority: normal
Component: Translate Site & Plugins Keywords:
Cc:

Description

I think that during translation review, when reviewing an individual string, it would be helpful to have the checkbox inside the edit panel.

When reviewing something from an individual string, you have to close the editor and then check the box to further process that translation along with others previously selected, to approve, etc.

The idea would be to keep the current checkboxes to the left of each translation string the same as now, and add the same checkbox to the individual translation panel as well, so you can check the checkbox from within the edit panel.

This would allow you to jump to the next translation string with the navigation arrows, without having to close the edit panel and select the checkbox on each edit.

I attach an image for better understanding.

Thanks

Attachments (2)

checkbox-in-translation-editor-panel.png (59.0 KB) - added by Marc4 12 months ago.
Approve.JPG (108.5 KB) - added by psmits1567 11 months ago.
Editor

Download all attachments as: .zip

Change History (16)

#1 @psmits1567
12 months ago

I do not think this is an improvement. If you select all records before starting the editor, then you do not have the need for an extra checkbox. Besides that if you go into the editor, and change the record, because that is the reason for opening it, you will save or start a discussion. Then it is also a duplicate action

#2 @Marc4
12 months ago

I do not think this is an improvement. If you select all records before starting the editor, then you do not have the need for an extra checkbox.

I assume navigation exists because it is useful for navigating between individual strings. I use it. Not always, but I use it very often. So having the checkbox there seems useful to me, because otherwise it forces me to go out to the overview just to select the checkbox.

Besides that if you go into the editor, and change the record, because that is the reason for opening it, you will save or start a discussion. Then it is also a duplicate action

The editor can be entered without having to change a record. If you review translations from the individual string navigation instead of checking the boxes from the overview.

It's not the most annoying thing in the world, but it's definitely not optimal. And it seems logical to me if cross-string navigation exists.

If navigation between individual strings didn't exist I wouldn't raise it. But if we have that option, from my point of view, it seems logical to also have the checkbox inside the editor.

#3 @psmits1567
12 months ago

As stated before, if you mark the records before going into the editor, you do not have this problem. It is just a matter of changing your workflow. When the records already have a checked status, it does not deliver a problem when going down through the records with the method you describe. I cannot imagine that going through the suggested records with your method is efficient. Normally I always read the originals in the list and check the translation. If not OK I go into the translation and provide discussion information.

#4 @LidiaLAB
11 months ago

Hi @Marc4,

with "navigation between individual strings" do you mean the use of PGUP/PGDOWN or Ctrl+Up-Arrow/Ctrl+Down-Arrow added by the WPGP Tools browser extension or a native function of the Translate site?

However I got what you mean with "not optimal". There can be situations where you first select all the checkboxes and then you go to do more deep evaluation of some translations (history, previous discussions, ...) and you may decide to revert that check before moving on to another particular translation that you want to better check before click on the approval bulk action and so on... Regardless the use of the arrow/pag keys I admit it's a bit annoying also to me.

#5 follow-up: @Marc4
11 months ago

Hi @LidiaLAB,

by "navigation" I meant the upper and lower arrows, to the right of the "X" that serves to close the individual WordPress native translation editor.

There may be situations where you first select all the checkboxes and then you are going to do a more in-depth evaluation of some translations (history, previous discussions, ...) and you may decide to revert that check before moving on to another particular translation

That is a good example. Another example is when I enter the individual editor in complex, or very long strings, where I need to check the history of previous translations or check how other local communities have done their translation, for example.

Based on this verification, I decide to check the box and then bulk approve all the correct strings. In that situation, you are already inside the editor, you can jump to the strings up or down, but you have to exit the editor to check the box.

If you then have multiple strings that need to be reviewed individually, you'll be going in and out of the editor, only to check the checkbox, when you could just check the box and keep scrolling down, with the arrow, until you want and then approve the strings in a bulk.

Version 0, edited 11 months ago by Marc4 (next)

#6 @psmits1567
11 months ago

Why not just inmediately approve the string if you decide it is OK??
Then if you have walked through, the ones you decided to check are done you can bulk select and approve the others. Walking through the translations this way takes more time than read the previews and only go into the editor if you want to check in depth. I do check 200 to 500 translation suggestions per day by just checking the ones I want to double check. I am working with OpenAI for in depth checking the suggestions. If you have a proper prompt, you will get decent translations from OpenAI. Also DeepL provides a reasonably suugestion.

#7 @Marc4
11 months ago

Why not just inmediately approve the string if you decide it is OK??

Maybe I'm doing something wrong, but when you try to click "Save" for a translation that is already correct, without making any changes to it, you get this error "Error: Identical current or waiting translation already exists. Dismiss" so it forces me to exit the editor, check the box and approve in bulk.

#8 @psmits1567
11 months ago

Hi @marc4 In this case you are indeed doing something wrong. If yo do not change anything and the translation is OK, then you can approve the string. The same way as you set it to "request changes". You do not need to bulk approve strings, then can be done one by one

#9 @Marc4
11 months ago

I can approve the string, but not from the editor. I have to check the box to approve a correct translation.

If you go into the editor to review a translation, because it is long, complex or whatever, decide it is correct and click "Save" you get that error. Then, in order to approve the string, you have to close the editor, check the box and approve, right?

#10 @psmits1567
11 months ago

No that is incorrect, you need to open the "Meta" tab if you are working this way
Than you have the buttons approve reject changes requested if it is a waiting string

@psmits1567
11 months ago

Editor

#11 @Marc4
11 months ago

Yes, you are right, that solves the example I posted, thanks :) But not solves the example posted by @LidiaLAB. Well, you would have to use Reject, right?

Last edited 11 months ago by Marc4 (previous) (diff)

#12 @psmits1567
11 months ago

The situation @LidiaLAB describes is a bit strange to me, because if you decide to not bulksave it, then you have made either a correction and saved it, or rejected, or made it a changes requested. Then there is no need to tick a box within the editor in my opinion.

#13 in reply to: ↑ 5 @LidiaLAB
11 months ago

by "navigation" I meant the upper and lower arrows, to the right of the "X" that serves to close the individual WordPress native translation editor.

Right!
I'm so used to press the PGUP/PGDOWN keys (a possibility added by the WPGP extension) that I no longer make attention to the arrows in the user interface. But the little difficulty about the ghosted checkbox it's the same.

#14 @LidiaLAB
11 months ago

The situations could be many.

For example at a first glance I might think that the majority of the translations in that page are good and I will want to approve all of them, but for a few of them I might want to uncheck only after seeing if there are good previous translations. At that point I need to open the right area and select the history tab on the right, from there I can simply press the PGDOWN key to see the same tab for each of the following rows. And if I have the checkbox still present in the row I could decide to uncheck the ones that have a good previous translation. Then at the end I could approve all those that are still selected by the bulk action.

I work with 100 strings per page, so for me this modus operandi is convenient.

Another example, I might also have the need to select the checkbox of a row after analyzing some details in the history tab or in the TM tab of the right area while I'm navigating through the rows with the arrows of the UI and make a bulk action only at the end, such as a rejection. Because the reject button is present only in the meta tab or because I want to reject with the same Changes Request all that translations. To me having that checkbox still present even when the row is expanded makes sense.

It's not a big deal, but it's something I've been wondering about for a while, I see another person is wondering the same thing.

The point is: why does the checkbox dissapear?

Note: See TracTickets for help on using tickets.