Opened 9 months ago

Closed 9 months ago

Last modified 8 months ago

#7213 closed defect (bug) (fixed)

GlotPress project not re-activated after a theme is unsuspended

Reported by: dd32's profile dd32 Owned by: dd32's profile dd32
Milestone: Priority: normal
Component: Theme Directory Keywords:


As reported in Slack by @kafleg, a theme may be listed as inactive on when the following conditions are met:

  1. The theme is suspended (temporarily)
  2. The theme is marked as published again
  3. The theme receives no further updates

Upon a theme being suspended, we mark it as inactive in GlotPress, but upon the theme moving from suspend to publish, we don't make the same call.

If a new version of the theme is submitted, that marks the theme as active in GlotPress.

Change History (7)

#1 @dd32
9 months ago

  • Owner set to dd32
  • Status changed from new to accepted

#2 @dd32
9 months ago

In 12845:

Theme Directory: When a theme is published, mark the GlotPress project and as available.

See #7213.

#3 @dd32
9 months ago

Sourced the themes that are labeled as unavailable, marked them as available.

See also: #7214

#4 @dd32
9 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

#5 @dufresnesteven
8 months ago

In 12915:

Theme Directory: Lower priotity of publish_repopackage action.

See: #7213

#6 @dufresnesteven
8 months ago

This has introduced a bug where is updated with a stale version of the "live" theme when a user uploads a new theme version.

#7 @iandunn
8 months ago

In 12917:

Theme Directory: Return when published to prevent duplicate imports

wporg_themes_glotpress_mark_as_active_on_publish() was only intended to run when a suspended/delisted theme was reinstated, but it was also running when a new version of a published theme was uploaded. That caused wporg_themes_update_wpthemescom() to run a second time, after it was originally called by the import process. The second time it was called with the _previous_ version of the theme, though, because it ran before the _status value was updated in the database. That caused previews on to always show the previous version instead of the current one.

Props iandunn, dufresnesteven, paulkevan
See #7213

Note: See TracTickets for help on using tickets.