RTL for wp.org local sites (rosetta)

[ramiy]

Hi guys,
it's Rami from he.wordpress.org.

Seems like the RTL version of rosetta is broken. Or, the theme was changed but the he_IL.css file was not updated accordingly.

You need to delete:

.wrapper { width: 858px; }

[SergeyBiryukov]

Confirmed. he_IL.css was removed in ​i18n:22662 (apparently it was no longer needed after ​[WP26783] and ​[WP26816]), but it still exists on global.wordpress.org.

[ramiy]

I confirm your confirmation, removing he_IL.css fixes all UI issues in ​http://he.wordpress.org/.

[ramiy]

Now i see that the site and the dashboard are both ltr.

[ramiy]

You need to set it as rtl to load the missing rtl.css file.

[samuelsidler]

Nacin fixed this up earlier today.

[SergeyBiryukov]

I still see he_IL.css loaded on the page with .wrapper { width: 858px; } in it. Is it supposed to be there? [987] didn't cover that.

[ocean90]

he_IL.css was re-added. I removed it from l18n repo and deleted it again. Seems like we also need a version bump for [987].

[ocean90]

Okay, we're talking about two different he_IL.css files. One which had existed in /wp-content and one in /rosetta. The one which is removed now is /rosetta. But that will break the site layout because not all styles are in wp4-rtl.css yet. I will try to migrate all the neccessay changes from he_IL.css to wp4-rtl.css now.

[ocean90]

After some coffee I noticed that we have rtl.css for Rosetta which I had deleted locally and therefore comment:8.

So the only thing we have do is to reset the font, see 729.patch​. (Includes some clean up.)

[SergeyBiryukov]

Replying to ocean90:

Okay, we're talking about two different he_IL.css files. One which had existed in /wp-content and one in /rosetta. The one which is removed now is /rosetta.

FWIW, I still see the one from /wp-content in the page source:
http://global.wordpress.org/wp-content/languages/css/he_IL.css?1416136182&ver=1

[ocean90]

Replying to SergeyBiryukov:

FWIW, I still see the one from /wp-content in the page source:

It's not deployed yet.

[samuelsidler]

In 992:

Rosetta theme: Fix some RTL issues. see #729. props ocean90

[samuelsidler]

We still need the wp4-rtl.css changes in the patch.

[ramiy]

Greate work guys, thanks!

[ocean90]

In 1066:

Further clean-up of global RTL styles.

fixes #729.