WordPress.org

Making WordPress.org

Opened 6 years ago

Closed 6 years ago

#74 closed defect (fixed)

Fix display of table rows containing multi-line content

Reported by: kpdesign Owned by: nacin
Milestone: Priority: low
Component: Make (Get Involved) / P2 Keywords: has-patch
Cc:

Description

Table rows with multiple lines of content in one of the cells don't display content in the other cells properly. Instead of all content floating to the top of the cell, it is aligned in the middle of the cell.

P2 doesn't have vertical-align set for .postcontent table td - the attached patch fixes the issue for the make.wordpress.org sites and associated handbooks.

See Make/Meta Project Queue and PHPDoc Tags Guide for live examples, and the attached "after patch" screenshot.

Attachments (3)

74-meta.patch (2.4 KB) - added by kpdesign 6 years ago.
Fix display of table cells containing multi-line content + miscellaneous formatting fixes
table-display-after.png (15.7 KB) - added by kpdesign 6 years ago.
Project Queue table with fix applied
74.1-meta.patch (587 bytes) - added by kpdesign 6 years ago.
Patch refresh: fix display of table cells containing multi-line content

Download all attachments as: .zip

Change History (7)

@kpdesign
6 years ago

Fix display of table cells containing multi-line content + miscellaneous formatting fixes

@kpdesign
6 years ago

Project Queue table with fix applied

#1 @iandunn
6 years ago

Hi Kim, thanks for the patch :)

It looks like you (or your editor) also did some formatting (e.g., changing the indentation levels, putting spacing between properties and values, etc). Those aren't necessarily bad things, but it's best to do any formatting fixes in a separate ticket/patch.

Could you re-create the patch with only the relevant changes, and then submit a new ticket/patch with the formatting changes? That would make the changes needed for #74 more obvious, and protect against losing the formatting changes if the commit were reverted for some reason.

@kpdesign
6 years ago

Patch refresh: fix display of table cells containing multi-line content

#2 @kpdesign
6 years ago

Hey Ian :) I've uploaded a new patch with just the change needed to fix the table row display. Will submit the new ticket with patch for formatting changes in a few minutes.

#3 @iandunn
6 years ago

Awesome, thanks :)

#4 @nacin
6 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 64:

WP.org P2: Fix display of multi-line table cell content. props kpdesign, fixes #74.

Note: See TracTickets for help on using tickets.