WordPress.org

Making WordPress.org

Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#741 closed defect (fixed)

Author shouldn't show as validators or be able to validate strings

Reported by: jnhghy Owned by: ocean90
Milestone: Priority: high
Component: International Sites (Rosetta) Keywords:
Cc:

Description

http://wpcentral.io/internationalization/ro/ shows an Author (Adrian Pop) as a validator and he is able to validate strings (he gets some error messages from time to time like Error: You are not allowed to do that!
If he logs out and back in he can validate without that message. It doesn't happen all the time and we don't know what can produce this issue.
He sure could validate strings as we checked it up.

Attachments (5)

741-glotpress.patch (10.3 KB) - added by ocean90 4 years ago.
741-api.patch (862 bytes) - added by ocean90 4 years ago.
741-muplugin.patch (26.3 KB) - added by ocean90 4 years ago.
741-profiles.patch (2.1 KB) - added by ocean90 4 years ago.
741-wp-i18n-teams.patch (997 bytes) - added by ocean90 4 years ago.

Download all attachments as: .zip

Change History (25)

#1 @samuelsidler
5 years ago

  • Component changed from translate.wordpress.org to International Sites (Rosetta)

This is a problem and appears to be an API/Rosetta issue.

#2 @deconf
5 years ago

And one more thing, Adrian was initially a contributor. During that time he was able to validate, so this ticket also applies to Contributor role.

Last edited 5 years ago by deconf (previous) (diff)

#3 @deconf
5 years ago

  • Cc admin@… added

#4 @ocean90
4 years ago

Looking at sites/trunk/translate.wordpress.org/includes/gp-plugins/wporg-rosetta-roles/wporg-rosetta-roles.php#L5 which says Anyone with the role of Validator, Contributor, Author, or Editor has the ability to validate strings for that language. So there is currently nothing wrong here.


Future improvements to this would make this more granular (i.e. per-project) with a UI in Rosetta to control those permissions.

Maybe we should try this.

This ticket was mentioned in Slack in #polyglots by ocean90. View the logs.


4 years ago

This ticket was mentioned in Slack in #polyglots by ocean90. View the logs.


4 years ago

This ticket was mentioned in Slack in #polyglots by deconf. View the logs.


4 years ago

#8 @ocean90
4 years ago

  • Owner set to ocean90
  • Status changed from new to accepted

@ocean90
4 years ago

This ticket was mentioned in Slack in #meta-i18n by ocean90. View the logs.


4 years ago

#10 @stephdau
4 years ago

Not an expert in the context, but the code looks solid, from my reading (all) of it.

#11 @ocean90
4 years ago

In 1419:

Rosetta: Extend roles plugin to allow per-project permissions for validators.

see #741, #519.

#12 @ocean90
4 years ago

In 1420:

Rosetta: Use $user->has_cap() to check if a user is already a translation editor.

see #741.

#13 @ocean90
4 years ago

In 1421:

Rosetta: Access $user->roles directly to check if a user is already a translation editor.

$user->has_cap() returns always true for super admins.

see #741.

#14 @ocean90
4 years ago

In 1422:

Rosetta: Add a "Promote to Translation Editor" action link to users list table.

see #741.

#15 @ocean90
4 years ago

In 1423:

Rosetta: Remove unused action.

see #741.

#16 @ocean90
4 years ago

In 1424:

Credits API: Use the new "translation_editor" role when grabbing validators.

see #741.

#17 @ocean90
4 years ago

In 1425:

Translate: Update Rosetta bridge to reflect new role/permissions system.

see #741.

#18 @ocean90
4 years ago

In 1426:

Rosetta: Remove deprecated validator role.

see #741.

#20 @ocean90
4 years ago

In 1437:

Rosetta: Fetch the correct access list for the projects column.

see #741.

Note: See TracTickets for help on using tickets.