Opened 10 years ago

Closed 8 years ago

#743 closed defect (bug) (fixed)

Update P2s with new icons

Reported by: ryelle's profile ryelle Owned by:
Milestone: Priority: normal
Component: Make (Get Involved) / P2 Keywords: has-patch


The icons on the cards were updated in #689, but they're also used on the P2s, and were not updated there. Now the P2s don't match the cards, and design is missing its icon (due to the ui -> design rename).

The icons on the P2s should be updated to use the profiles icons.

Attachments (1)

make-icons.diff (1.9 KB) - added by ryelle 10 years ago.

Download all attachments as: .zip

Change History (7)

10 years ago

#1 @ryelle
10 years ago

  • Keywords has-patch added

make-icons.diff updates the icons and fixes the design selector (from .make-ui to .make-design).

I also forgot to mention in the initial description that Cyndy Otty (ceo) was the one who noticed this.

Last edited 10 years ago by ryelle (previous) (diff)

This ticket was mentioned in Slack in #meta by ryelle. View the logs.

9 years ago

#3 @melchoyce
9 years ago

Looks like this may have been fixed but the ticket wasn't closed. Is that correct? The icons on look to match @ryelle's patch now.

#4 @ryelle
9 years ago

It's not -- I made the same mistake when I brought this up on slack. This ticket is for updating the individual make sites - for example, the docs card has the page icon, like the badges, but still has the aiside icon.

#5 @melchoyce
9 years ago

Oh! Whoops. :) Thanks for clarifying.

#6 @ocean90
8 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in [2193] and [2194].

Note: See TracTickets for help on using tickets.