#7504 closed defect (bug) (fixed)
Language guess on support forums isn't working
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Component: | Support Forums | Keywords: | |
Cc: |
Description (last modified by )
The support forums homepage has a language guess banner, but it currently does nothing. This is due to the mu-plugin and ajax endpoint both only handling /support/
and not /support/forums/
.
See
https://dotorg.trac.wordpress.org/browser/wordpress/website/wp-content/mu-plugins/main-network/lang-guess.php#L12
https://dotorg.trac.wordpress.org/browser/wordpress/website/lang-guess/lang-guess-ajax.php#L36
https://dotorg.trac.wordpress.org/browser/wordpress/website/lang-guess/lang-guess-ajax.php#L110
Change History (7)
#3
follow-up:
↓ 5
@
12 months ago
- Resolution fixed deleted
- Status changed from closed to reopened
Thanks for working on this @dd32, I think we need one more change. The banner is correctly detecting that it's on the support forums now, but the link is pointing to /support/
, not /support/forums/
, here's the German version:
This is set on https://dotorg.trac.wordpress.org/browser/wordpress/website/lang-guess/lang-guess-ajax.php#L110
What do you think?
#4
@
12 months ago
- Resolution set to fixed
- Status changed from reopened to closed
Actually there is ongoing discussion related to where this link should land. I think we're good for now.
#5
in reply to:
↑ 3
;
follow-up:
↓ 6
@
12 months ago
Replying to adamwood:
Thanks for working on this @dd32, I think we need one more change. The banner is correctly detecting that it's on the support forums now, but the link is pointing to
/support/
, not/support/forums/
Yeah, this was intentional; AFAIK only the english forums is /support/forums/
currently (and that's a problem to me) and this never suggests the english forums.
#6
in reply to:
↑ 5
@
12 months ago
Replying to dd32:
Replying to adamwood:
Thanks for working on this @dd32, I think we need one more change. The banner is correctly detecting that it's on the support forums now, but the link is pointing to
/support/
, not/support/forums/
Yeah, this was intentional; AFAIK only the english forums is
/support/forums/
currently (and that's a problem to me) and this never suggests the english forums.
Cool, yeah I understand the first comment now, sorry :)
r21757-dotorg:
I don't think there's anything that links to
wordpress.org/support/
in lang guess, as we don't currently suggest non-en locales go to en.