Making WordPress.org

Opened 5 months ago

Closed 5 months ago

Last modified 4 months ago

#7504 closed defect (bug) (fixed)

Language guess on support forums isn't working

Reported by: adamwood's profile adamwood Owned by:
Milestone: Priority: normal
Component: Support Forums Keywords:
Cc:

Change History (7)

#1 @adamwood
5 months ago

  • Description modified (diff)

#2 @dd32
5 months ago

  • Resolution set to fixed
  • Status changed from new to closed

r21757-dotorg:

Lang guess: Support `/support/forums/` as a support forums homepage.

See https://meta.trac.wordpress.org/ticket/7504

I don't think there's anything that links to wordpress.org/support/ in lang guess, as we don't currently suggest non-en locales go to en.

#3 follow-up: @adamwood
5 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Thanks for working on this @dd32, I think we need one more change. The banner is correctly detecting that it's on the support forums now, but the link is pointing to /support/, not /support/forums/, here's the German version:

https://cldup.com/RlvivGwjuW.jpg

This is set on https://dotorg.trac.wordpress.org/browser/wordpress/website/lang-guess/lang-guess-ajax.php#L110

What do you think?

#4 @adamwood
5 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

Actually there is ongoing discussion related to where this link should land. I think we're good for now.

#5 in reply to: ↑ 3 ; follow-up: @dd32
5 months ago

Replying to adamwood:

Thanks for working on this @dd32, I think we need one more change. The banner is correctly detecting that it's on the support forums now, but the link is pointing to /support/, not /support/forums/

Yeah, this was intentional; AFAIK only the english forums is /support/forums/ currently (and that's a problem to me) and this never suggests the english forums.

#6 in reply to: ↑ 5 @adamwood
5 months ago

Replying to dd32:

Replying to adamwood:

Thanks for working on this @dd32, I think we need one more change. The banner is correctly detecting that it's on the support forums now, but the link is pointing to /support/, not /support/forums/

Yeah, this was intentional; AFAIK only the english forums is /support/forums/ currently (and that's a problem to me) and this never suggests the english forums.

Cool, yeah I understand the first comment now, sorry :)

This ticket was mentioned in Slack in #meta by courtneyengle. View the logs.


4 months ago

Note: See TracTickets for help on using tickets.