Run PCP function to test plugin in plugin submission process

[barrykooij]

When a user submits a new plugin to the directory, we want to run a function within PCP which checks if the new submission passes a collection of automated checks. If not, we want to block the submission and inform the user why.

The first version within PCP would be a set of PHPCS rules that are always blocking. Later we can expand on this with for example a readme parser. We are discussing what PHPCS rules should be included on Github: ​https://github.com/WordPress/plugin-check/issues/440

This trac ticket is to talk about if this is possible and how we can do this.

[dd32]

To integrate it...

The minimum we need to know is:

• Whether this plugin is a PASS or FAIL.
• Any errors/warnings/notes etc.

A pass with a long list of errors is acceptable, if those errors might be false-positives, as long as we have a way of knowing that it's a PASS/FAIL.

What we need code wise:

• A function (or class method, or even WP-CLI command!) that can be provided an arbritrary folder on disk (ie. /tmp/plugin-submission-123oeiwlsf), any metadata about the plugin needed (ie. WordPress.org uploader name), and can return the above information.

[davidperez]

Hello! Could you give us more detail of the output that plugin will make? An array? json? etc? We actually have a WP CLI and we could make a Class as well. Could you give us what is more convenient for you?

[barrykooij]

Replying to davidperez:

Hello! Could you give us more detail of the output that plugin will make? An array? json? etc? We actually have a WP CLI and we could make a Class as well. Could you give us what is more convenient for you?

Hey David. This is clear on our end. We will create a function that can be called within meta. This will return a bool (PASS/FAIL) and an array with "results"(strings) (Any errors/warnings/notes etc.)

[davidperez]

Ok @barrykooij . Thanks for the clarification.