Making WordPress.org

Opened 6 weeks ago

Closed 6 weeks ago

Last modified 6 weeks ago

#7597 closed defect (bug) (fixed)

Plugin Review Submission - Change the date for new version uploads

Reported by: foosantos's profile foosantos Owned by: dd32's profile dd32
Milestone: Priority: high
Component: Plugin Directory Keywords: needs-patch has-screenshots
Cc:

Description

When a plugin author uploads a new plugin version on the submission page, we automatically add a note to their review conversation on Help Scout and change the status to active.

One of the challenges is that the note doesn't change the last interaction date on the conversation. We would like for it to work in a way that updates this data accordingly to match the last reply or upload.

  1. Submit a plugin (as the user)
  2. Start the review (as the reviewer)
  3. Upload a new version on the submission page (as the user)
  4. Go to the conversation on Help Scout and confirm that the note was added
  5. Go to the "Assigned" conversations on Help Scout and see that the date has not changed based on this update

Attachments (1)

waiting-since-not-updated.png (159.1 KB) - added by foosantos 6 weeks ago.

Download all attachments as: .zip

Change History (5)

#1 @dd32
6 weeks ago

The Waiting Since references the last email from a customer in the thread, since we're adding a Note, it doesn't update it.

Instead of adding a note, we can add a reply to the thread, which will bump the date.

There's two options from there though;

  1. Set as an "imported" reply, HelpScout will not send emails in this case. No notifications happen (ie. If you're assigned the HS ticket, you won't get an email about the update)
  2. Set as a normal reply, HelpScout will send the plugin author the email as well as adding to the email thread, HelpScout emails to the assigned reviewer will be triggered.

In both cases, the Name of the reply will list the Systems user as being the reply author.

Out of the above options, 1 seems to be the safest option, as it won't cause emails to be sent to the end-user.
2 seems to be appropriate though; with the caveat that we'll only ever be able to add public information to the email thread. That seems fine, to me.. With #7598 they'll also get a copy of their feedback / notes for the upload.

The other option would be to add the reply, and a note with any private details (Which currently the ZIP is the only kinda 'secret' data, and it's not sensitive or need to be secret IMHO).

#2 @foosantos
6 weeks ago

The option two really seems to be ideal. Thank you so much, Dion!

Folks on the team mentioned that sometimes authors aren't sure if the submission worked and end up resending the plugin in other ways (dropbox, etc.), so sending this email message should have this side benefit.

#3 @dd32
6 weeks ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 13574:

Plugin Directory: Review: Add the New ZIP uploaded HelpScout notice as a reply rather than as a note.

This causes the threads 'Waiting Since' to reset to the ZIP upload time, and for plugin authors to get a confirmation email that the upload has succeeded.

Fixes #7597.

#4 @foosantos
6 weeks ago

I tested it here from my end, and it appears to be working perfectly! Thank you.

Note: See TracTickets for help on using tickets.