Making WordPress.org

Opened 8 months ago

Closed 8 months ago

Last modified 8 months ago

#7663 closed defect (bug) (fixed)

Plugin submission: Change texts referring to the previous submission process.

Reported by: frantorres's profile frantorres Owned by: dd32's profile dd32
Milestone: Priority: normal
Component: Plugin Directory Keywords: has-patch
Cc:

Description

There are some strings that refer to the previous plugin submission process, I suggest changing them as follows:

https://meta.trac.wordpress.org/browser/sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/shortcodes/class-upload.php#L175

  • Change: "Please reply to that email with your corrected code attached or linked in order to proceed with the review.".
  • To: "Please continue the review process by following the steps indicated in that email."

https://wordpress.org/plugins/developers/add/

  • Change: "I made a mistake in my plugin name. Should I resubmit?"
  • To: "I made a mistake in my plugin name. Should I update it?"
  • Change: "Please don’t! Instead email plugins@... and we can rename your plugin as long as it’s not approved. Since we check emails first, the odds are we’ll catch it. If we don’t, just email us and explain the mistake. We’ll explain what to do."
  • To: "It depends on what you want to change. If you want to change the plugin display name, you can update that by updating your plugin files in this page. If what you want to change is the permalink / slug of your plugin, you can do that ONCE before we begin with the review (if that’s available you’ll see a link to change it in this page). If this is not possible, you will need to contact us at plugins@... , we can change it as long as the plugin is not yet approved."

(Note that the email is obfuscated)

Attachments (2)

7663.diff (3.2 KB) - added by naeemhaque 8 months ago.
Changes for #7663
#7663.diff (4.0 KB) - added by naeemhaque 8 months ago.
new patch with applied all chnages

Download all attachments as: .zip

Change History (10)

@naeemhaque
8 months ago

Changes for #7663

#1 @naeemhaque
8 months ago

  • Keywords has-patch added

Hello @frantorres ,

I have created a patch that updates the strings you mentioned regarding the previous plugin submission process.
I found your first two suggestions. However, I could not find the third one in GitHub files. So I have left it unchanged.

@naeemhaque
8 months ago

new patch with applied all chnages

#3 in reply to: ↑ 2 @naeemhaque
8 months ago

Replying to frantorres:

Hi @naeemhaque thanks! I checked and see that the third one is here: https://meta.trac.wordpress.org/browser/sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-plugins/page-add.php#L72

Hi @frantorres,
Thanks for assisting me in finding the correct file with your clear explanation.
I have applied the updates to my patch #7663.diff as per your suggestion.
Thank you.

#4 @frantorres
8 months ago

Patch looks great, thanks!

Last edited 8 months ago by frantorres (previous) (diff)

#5 follow-up: @dd32
8 months ago

A new patch is not needed; but as a note @naeemhaque

  • themes/pub/wporg-plugins is no longer in use, and it's been replaced with themes/pub/wporg-plugins-2024.
  • When changing strings in _n() type functions you need to replace both strings, one is the "singular" and the other is the plural.

#6 @dd32
8 months ago

  • Owner set to dd32
  • Resolution set to fixed
  • Status changed from new to closed

In 13771:

Plugin Directory: Update strings to reflect new plugin submission process.

Props frantorres, naeemhaque, dd32.
Fixes #7663.

#7 @dd32
8 months ago

In 13773:

Plugin Directory: Correct the translation comment of a string.

See #7663, [13771].

#8 in reply to: ↑ 5 @naeemhaque
8 months ago

Replying to dd32:

A new patch is not needed; but as a note @naeemhaque

  • themes/pub/wporg-plugins is no longer in use, and it's been replaced with themes/pub/wporg-plugins-2024.
  • When changing strings in _n() type functions you need to replace both strings, one is the "singular" and the other is the plural.

Hello @dd32, Thanks for sharing this.

Last edited 8 months ago by naeemhaque (previous) (diff)
Note: See TracTickets for help on using tickets.