WordPress.org

Making WordPress.org

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#768 closed defect (invalid)

meta potbot: reporting against incorrect changesets

Reported by: netweb Owned by:
Milestone: Priority: normal
Component: General Keywords:
Cc:

Description

meta potbot is reporting against incorrect changesets.

Example:

  • potbot made a commit, r1025 6 days ago
  • potbot believes this was against r1024
  • it was in fact against r962 from four weeks ago

Expected:

  • potbot runs against most recent commit and reports correct changeset

Change History (8)

#1 @netweb
5 years ago

Nacin in Slack here

"..it simply says it is generating the current revision, not the actual revision a string might have been changed from. so it's "current to rev 1080"

This makes sense, thus making 90% of this ticket worksforme.

The only thing is the timeliness of potbot's runs, is this automated or manually run?

If automated a little more frequently than once a month would be beneficial IMHO.

This ticket was mentioned in Slack in #meta by netweb. View the logs.


5 years ago

#3 follow-up: @nacin
5 years ago

  • Resolution set to invalid
  • Status changed from new to closed

It runs every hour but it'll only commit anything if there's something to commit.

#4 in reply to: ↑ 3 ; follow-up: @netweb
5 years ago

Replying to nacin:

It runs every hour but it'll only commit anything if there's something to commit.

Has this changed recently? Per the original ticket r1025 was committed four weeks after the r962 commit

#5 @netweb
5 years ago

  • Resolution invalid deleted
  • Status changed from closed to reopened

Also r1081 was only a date (year) change in wpmobileapps.pot, the previous string change in that repo was that same r962 commit mentioned above ~8 weeks ago.

If potbot believes that the year change is valid enough to run for a date change withwpmobileapps.pot should it not then run the same for other .pot files throughout meta?

#6 in reply to: ↑ 4 @nacin
5 years ago

Replying to netweb:

Has this changed recently? Per the original ticket r1025 was committed four weeks after the r962 commit

It is occasionally disabled (or broken or frozen). It was un-frozen on December 4.

should it not then run the same for other .pot files throughout meta?

It only runs for .pot files for which it is configured to run.

#7 @netweb
5 years ago

  • Resolution set to invalid
  • Status changed from reopened to closed

Thanks, makes sense now :)

This ticket was mentioned in Slack in #polyglots by netweb. View the logs.


5 years ago

Note: See TracTickets for help on using tickets.