Making WordPress.org

Opened 5 months ago

Closed 3 months ago

#7722 closed defect (bug) (fixed)

New Core Committers (Gutenberg + Core Unification)

Reported by: ellatrix's profile ellatrix Owned by: dd32's profile dd32
Milestone: Priority: normal
Component: Version Control Keywords:
Cc:

Description (last modified by dd32)

Background: https://wordpress.slack.com/archives/C18723MQ8/p1718813555619569
Approval: https://wordpress.slack.com/archives/C18723MQ8/p1720368966725729?thread_ts=1718813555.619569&cid=C18723MQ8

Announcement: https://make.wordpress.org/core/2024/07/22/aligning-committer-level-access-across-the-code-base/

WordPress.org usernames: @0mirka00, @aaronrobertshaw, @andraganescu, @andrewserong, @aristath, @cbravobernal, @czapla, @get_dave, @glendaviesnz, @jameskoster, @kevin940726, @luisherranz, @mciampini, @mikachan, @nerrad, @ntsekouras, @ramonopoly, @richtabor, @scruffian, @tyxla, @wildworks.

Checklist and tasks form the handbook: https://make.wordpress.org/core/handbook/best-practices/when-you-become-a-committer/.

Please read and leave a comment here when each of you went through these steps. Thank you!

Change History (30)

This ticket was mentioned in Slack in #meta by ella. View the logs.


5 months ago

#2 @mciampini
5 months ago

Thank you, Ella.

  • ✅ Updated and strengthened passwords, stored in a secure password manager;
  • ✅ 2FA enabled on GitHub, Slack, and email provider;
  • ✅ Joined #core-committers channel on Slack;
  • ✅ Added mciampini@git.wordpress.org to my GitHub account;
  • ✅ Read the guide on commit messages;
  • ✅ I will ask a relevant committer to peer-review my first few patches and in general any time I have doubts about the patch I'm working on;
  • ✅ I will work with the community during contributor days, helping to commit someone else's code, and encouraging folks (especially inactive committers) to become active contributors again.
Last edited 5 months ago by mciampini (previous) (diff)

#3 @scruffian
5 months ago

✅ Updated and strengthened WordPress.org password and enabled 2FA.
✅ Enabled 2FA on Slack (It was already on GitHub and email provider).
✅ Joined #core-committers channel on Slack.
✅ [Already added scruffian@… to GitHub]
✅ Read the guide on commit messages;
✅ I will ask a relevant committer to peer-review my first few patches and in general any time I have doubts about the patch I'm working on;
✅ I will work with the community during contributor days, helping to commit someone else's code, and encouraging folks (especially inactive committers) to become active contributors again.

#4 @tyxla
5 months ago

✅ I have extra long and strong passwords
✅ 2FA is enabled for GitHub, Slack, and email
✅ Joined #core-committers in Slack
✅ WP.org Git email added to GitHub profile
✅ Read the commit message guidelines
✅ Acknowledged I should ask for peer review of my first few commits or if I have any doubts about what I'm committing.
✅ Acknowledged I should consider helping with committing code of others on WordCamp contributor day and encourage inactive committers to participate again.

Thanks, Ella

#5 @nerrad
5 months ago

✅ I have extra long and strong passwords
✅ 2FA is enabled for GitHub, Slack, and email
✅ Joined #core-committers in Slack
✅ WP.org Git email added to GitHub profile
✅ Read the commit message guidelines
✅ Acknowledged I should ask for peer review of my first few commits or if I have any doubts about what I'm committing.
✅ Acknowledged I should consider helping with committing code of others on WordCamp contributor day and encourage inactive committers to participate again.

Thanks!

#6 @cbravobernal
5 months ago

✅ I have extra long and strong passwords
✅ 2FA is enabled for GitHub, Slack, and email
✅ Joined #core-committers in Slack
✅ WP.org Git email added to GitHub profile
✅ Read the commit message guidelines
✅ Acknowledged I should ask for peer review of my first few commits or if I have any doubts about what I'm committing.
✅ Acknowledged I should consider helping with committing code of others on WordCamp contributor day and encourage inactive committers to participate again.

Thanks!

#7 @andrewserong
5 months ago

✅ Updated and strengthened WordPress.org password and enabled 2FA.
✅ Enabled 2FA on Slack (like others, it was already on GitHub and email provider).
✅ Joined #core-committers channel on Slack.
✅ [Already added andrewserong@… to GitHub]
✅ Read the guide on commit messages; laughed at the line "Otherwise, consult a thesaurus."
✅ I will ask a relevant committer to peer-review my first few patches and in general any time I have doubts about the patch I'm working on;
✅ I will work with the community during contributor days, helping to commit someone else's code, and encouraging folks (especially inactive committers) to become active contributors again.

Thank you!

#8 @mikachan
5 months ago

✅ I have extra long and strong passwords
✅ 2FA is enabled for GitHub, Slack, and email
✅ Joined #core-committers in Slack
✅ WP.org Git email added to GitHub profile
✅ Read the commit message guidelines
✅ Acknowledged I should ask for peer review of my first few commits or if I have any doubts about what I'm committing.
✅ Acknowledged I should consider helping with committing code of others on WordCamp contributor day and encourage inactive committers to participate again.

Thank you!

#9 @luisherranz
5 months ago

✅ I have extra long and strong passwords
✅ 2FA is enabled for GitHub, Slack, and email
✅ Joined #core-committers in Slack
✅ WP.org Git email added to GitHub profile
✅ Read the commit message guidelines
✅ Acknowledged I should ask for peer review of my first few commits or if I have any doubts about what I'm committing.
✅ Acknowledged I should consider helping with committing code of others on WordCamp contributor day and encourage inactive committers to participate again.

Thank you 🙂

#10 @richtabor
5 months ago

✅ I have extra long and strong passwords
✅ 2FA is enabled for GitHub, Slack, and email
✅ Joined #core-committers in Slack
✅ WP.org Git email added to GitHub profile
✅ Read the commit message guidelines
✅ Acknowledged I should ask for peer review of my first few commits or if I have any doubts about what I'm committing.
✅ Acknowledged I should consider helping with committing code of others on WordCamp contributor day and encourage inactive committers to participate again.

Cheers!

#11 @ramonopoly
5 months ago

✅ I have long and strong passwords, stored in a password manager
✅ 2FA is enabled for GitHub, Slack, email and all other services associated with my wp.org activity.
✅ Joined #core-committers in Slack
✅ WP.org Git email added to GitHub profile
✅ I have read the commit message guidelines
✅ I will ask for peer review of my first few commits, or if I have any doubts about what I'm committing.
✅ I will help with committing code of others on WordCamp contributor day, and encourage inactive committers to participate again.

Thanks a lot!

#12 @ntsekouras
5 months ago

✅ I have long and strong passwords, stored in a password manager
✅ 2FA enabled on GitHub, Slack, and email provider;
✅ Joined #core-committers channel on Slack;
✅ I have added ntsekouras@… to my GitHub account;
✅ Read the guide on commit messages;
✅ I will ask a relevant committer to peer-review my first few patches and in general any time I have doubts about the patch I'm working on;
✅ I will work with the community during contributor days, helping to commit someone else's code, and encouraging folks (especially inactive committers) to become active contributors again.

Last edited 5 months ago by ntsekouras (previous) (diff)

#13 @desrosj
5 months ago

#7727 was marked as a duplicate.

#14 @0mirka00
5 months ago

✅ Long and strong passwords
✅ 2FA enabled for GitHub, Slack, and email
✅ Joined #core-committers in Slack
✅ WP.org Git email added to GitHub profile
✅ Read the guide on commit messages
✅ I will ask a relevant committer to peer-review my first few patches and any time I have doubts
✅ I will work with the community during contributor days

#15 @jameskoster
5 months ago

✅ Long and strong passwords
✅ 2FA enabled for GitHub, Slack, and email
✅ Joined #core-committers in Slack
✅ WP.org Git email added to GitHub profile
✅ Read the guide on commit messages
✅ I will ask a relevant committer to peer-review my first few patches and any time I have doubts
✅ I will work with the community during contributor days

#16 @aaronrobertshaw
5 months ago

✅ I have long and strong passwords
✅ 2FA is enabled for GitHub, Slack, email, and all other services associated with my wp.org activity
✅ Joined #core-committers in Slack
✅ WP.org Git email added to GitHub profile
✅ I have read the commit message guidelines
✅ I will ask for peer review of my first few commits, or if I have any doubts about what I'm committing.
✅ I will help with committing code of others on WordCamp contributor day, and encourage inactive committers to participate again.

Cheers!

#17 @glendaviesnz
5 months ago

✅ I have extra long and strong passwords
✅ 2FA is enabled for GitHub, Slack, and email
✅ Joined #core-committers in Slack
✅ WP.org Git email added to GitHub profile
✅ Read the commit message guidelines
✅ Acknowledged I should ask for peer review of my first few commits or if I have any doubts about what I'm committing.
✅ Acknowledged I should consider helping with committing code of others on WordCamp contributor day and encourage inactive committers to participate again.
Thanks, Ella

#18 @dd32
5 months ago

  • Description modified (diff)

Noting that @talldanwp and @joen already had commit.

#20 @dd32
5 months ago

Congrats everyone! No conTracts needed, oops

  • You now have SVN commit access (If you've confirmed the above), please work with your buddies/#core-committers on the first few commits if you're unsure.
  • Please join #core-committers
  • Being a committer also gains you access to @here in all #core-... channels, please use /here to perform an announcement, you can run it without any message after it to verify it (It'll echo a message to you).
  • This has disabled password resets for your accounts, to protect your account against potential takeovers. If you ever need to reset your account password, you'll need to talk to a WordPress.org dev or email the password reset team.

FYI @andraganescu @get_dave we're still waiting on your confirmation of the above, but I've added the Trac label and announce access early.

  • It looks like someone has already updated the Core Trac committer group too.
  • Slack committers ping group updated
  • Haven't touched GitHub Teams
Last edited 4 months ago by dd32 (previous) (diff)

#21 @wildworks
5 months ago

✅ I have extra long and strong passwords
✅ 2FA is enabled for GitHub, Slack, and email
✅ Joined #core-committers in Slack
✅ WP.org Git email added to GitHub profile
✅ Read the commit message guidelines
✅ Acknowledged I should ask for peer review of my first few commits or if I have any doubts about what I'm committing.
✅ Acknowledged I should consider helping with committing code of others on WordCamp contributor day and encourage inactive committers to participate again.

Thank you!

#22 @aristath
5 months ago

✅ Updated and strengthened passwords, stored in a secure password manager;
✅ 2FA enabled on GitHub, Slack, and email provider;
✅ Joined #core-committers channel on Slack;
✅ WP.org Git email added to GitHub profile
✅ Read the guide on commit messages;
✅ Acknowledged I should ask for peer review of my first few commits or if I have any doubts about what I'm committing.
✅ Acknowledged I should consider helping with committing code of others on WordCamp contributor day and encourage inactive committers to participate again.

Thank you!!

#23 follow-up: @nerrad
5 months ago

FYI @andraganescu @czapla @get_dave @kevin940726 @nerrad we're still waiting on your confirmation of the above, but I've added the Trac label and announce access early.

@dd32 I added my confirmation here: https://meta.trac.wordpress.org/ticket/7722#comment:5 - is there something else I'm missing confirming?

#24 @czapla
5 months ago

✅ I have extra long and strong passwords
✅ 2FA is enabled for GitHub, Slack, and email
✅ Joined #core-committers in Slack
✅ WP.org Git email added to GitHub profile
✅ Read the commit message guidelines
✅ Acknowledged I should ask for peer review of my first few commits or if I have any doubts about what I'm committing.
✅ Acknowledged I should consider helping with committing code of others on WordCamp contributor day and encourage inactive committers to participate again.

Thank you all!

#25 in reply to: ↑ 23 @dd32
5 months ago

Replying to nerrad:

dd32 I added my confirmation here

Apologies! I missed it while going through each of the comments! You're good to go :)

That's what happens when you're trying to sync between 4 different lists of people... It looks like I marked the wrong person off :D

Last edited 5 months ago by dd32 (previous) (diff)

#26 @kevin940726
4 months ago

✅ I have extra long and strong passwords
✅ 2FA is enabled for GitHub, Slack, and email
✅ Joined #core-committers in Slack
✅ WP.org Git email added to GitHub profile
✅ Read the commit message guidelines
✅ Acknowledged I should ask for peer review of my first few commits or if I have any doubts about what I'm committing.
✅ Acknowledged I should consider helping with committing code of others on WordCamp contributor day and encourage inactive committers to participate again.

Thank you!

#27 @dd32
4 months ago

  • Component changed from General to Version Control
  • Owner set to dd32
  • Status changed from new to accepted

Thanks for confirming @kevin940726!

I believe those who are remaining are on leave right now, so will follow up when they're next active.

#28 @get_dave
4 months ago

✅ Updated and strengthened passwords, stored in a secure password manager;
✅ 2FA enabled on GitHub, Slack, and email provider;
✅ Joined #core-committers channel on Slack;
✅ WP.org Git email added to GitHub profile
✅ Read the guide on commit messages;
✅ Acknowledged I should ask for peer review of my first few commits or if I have any doubts about what I'm committing.
✅ Acknowledged I should consider helping with committing code of others on WordCamp contributor day and encourage inactive committers to participate again.

Thanks!

#29 @andraganescu
3 months ago

✅ I have extra long and strong passwords
✅ 2FA is enabled for GitHub, Slack, and email
✅ Joined #core-committers in Slack
✅ WP.org Git email added to GitHub profile
✅ Read the commit message guidelines
✅ Acknowledged I should ask for peer review of my first few commits or if I have any doubts about what I'm committing.
✅ Acknowledged I should consider helping with committing code of others on WordCamp contributor day and encourage inactive committers to participate again.

#30 @dd32
3 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

Final tasks done, Thanks for confirming!

Follow up in #core-committers if you run into any issues

Note: See TracTickets for help on using tickets.