Photo Directory: Can't combine search and taxonomy filtering

[ryelle]

The ​new design will enable searching combined with the taxonomy filters, for example on the Theme Directory you can ​search for "school" themes with the accessibility-ready tag. This is native functionality in core, but isn't working on the Photo Directory.

For example, ​this photo has "vibrant" in the alt text, and is tagged with the color blue. But nothing appears in the result here: ​https://wordpress.org/photos/search/vibrant/?photo_color=blue

Locally, I see an error "Not unique table/alias: 'wp_term_relationships'". It appears the customization for search results is conflicting with the core behavior.

[ryelle]

7815.diff​ adds table aliases for the joined tables, which in combination with the patch on #7814 makes the search work as expected and prevents the table collisions in ​my local env. But like #7814, this isn't working on my sandbox.

[coffee2code]

In 14181:

Photo Directory, Search: Prevent table name collisions in searches with an explicit taxonomy.

Props ryelle.
See #7815.

[ryelle]

In 14224:

Photo Directory: Prevent ElasticSearch from being used on search results.

When active, ElasticSearch takes over the searching process and ignores the customization to search custom taxonomies, and prevents the core behavior of combining search and taxonomy filtering. Disabling it allows the search code to run as expected.

See #7814, #7815

[coffee2code]

Fixed as a result of [14224]. Also see comments in #7814.