Making WordPress.org

Opened 3 months ago

Closed 3 months ago

Last modified 3 months ago

#7829 closed defect (bug) (worksforme)

Dashicons page: add missing icons

Reported by: wildworks's profile wildworks Owned by:
Milestone: Priority: normal
Component: Developer Hub Keywords:
Cc:

Description

I noticed that there were two icons missing from the Dashicons page. These two icons have CSS defined for them:

The following three icons are also missing, but there is no need to add them because the same icons exist without the -duplicate suffix.

  • lock-duplicate
  • arrow-up-duplicate
  • editor-code-duplicate

Change History (5)

#1 @dd32
3 months ago

  • Component changed from General to Developer Hub

The code behind the dashicons page is available here for PRs:
https://github.com/WordPress/wporg-developer/blob/623f566dc1662fcb8bb36675b71835037e34ef02/source/wp-content/themes/wporg-developer-2023/inc/dashicons.php#L16

Would you be able to file this over there @wildworks? Or create a PR?

#2 @dd32
3 months ago

  • Resolution set to worksforme
  • Status changed from new to closed

#3 follow-up: @wildworks
3 months ago

@dd32 Thanks for the feedback.

Looks like the Google+ icon is intentionally not shown:

I haven't been able to find the reason, but do you know why this icon is commented out?

If there is a reason, I think we can close this ticket.

#4 in reply to: ↑ 3 @dd32
3 months ago

Replying to wildworks:

Looks like the Google+ icon is intentionally not shown:

do you know why this icon is commented out?

Google+ was shuttered in 2019 and no longer accessible or usable, so it's kinda pointless to show it :)

Looks like it was removed via [10186] / #5172.

#5 @wildworks
3 months ago

Ok, then we can close this ticket :)

Note: See TracTickets for help on using tickets.