#7829 closed defect (bug) (worksforme)
Dashicons page: add missing icons
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Component: | Developer Hub | Keywords: | |
Cc: |
Description
I noticed that there were two icons missing from the Dashicons page. These two icons have CSS defined for them:
googleplus
: https://github.com/t-hamano/wordpress-develop/blob/a27e6a8ecd5279a45e47ef88d048643740d07b5a/src/wp-includes/css/dashicons.css#L771-L773grid-view
: https://github.com/t-hamano/wordpress-develop/blob/a27e6a8ecd5279a45e47ef88d048643740d07b5a/src/wp-includes/css/dashicons.css#L775-L777
The following three icons are also missing, but there is no need to add them because the same icons exist without the -duplicate
suffix.
lock-duplicate
arrow-up-duplicate
editor-code-duplicate
Change History (5)
#2
@
3 months ago
- Resolution set to worksforme
- Status changed from new to closed
Looks like the Google+ icon is intentionally not shown:
https://github.com/WordPress/wporg-developer/blob/623f566dc1662fcb8bb36675b71835037e34ef02/source/wp-content/themes/wporg-developer-2023/inc/dashicons.php#L1099-L1105
And the Grid view appears to be there:
https://developer.wordpress.org/resource/dashicons/#grid-view
I don't think there's any changes needed here actually?
#3
follow-up:
↓ 4
@
3 months ago
@dd32 Thanks for the feedback.
Looks like the Google+ icon is intentionally not shown:
I haven't been able to find the reason, but do you know why this icon is commented out?
If there is a reason, I think we can close this ticket.
The code behind the dashicons page is available here for PRs:
https://github.com/WordPress/wporg-developer/blob/623f566dc1662fcb8bb36675b71835037e34ef02/source/wp-content/themes/wporg-developer-2023/inc/dashicons.php#L16
Would you be able to file this over there @wildworks? Or create a PR?