Making WordPress.org

Opened 4 months ago

Closed 4 months ago

Last modified 4 months ago

#7911 closed defect (bug) (fixed)

Participants column title is not translated

Reported by: timse201's profile timse201 Owned by: dd32's profile dd32
Milestone: Priority: normal
Component: International Forums Keywords: has-patch
Cc:

Description

The column titles are used form bbPress. But Participants is not used there.

https://de.wordpress.org/support/view/all-topics/

Change History (6)

This ticket was mentioned in PR #472 on WordPress/wordpress.org by @timse201.


4 months ago
#1

  • Keywords has-patch added

All strings are already used in loop-reply-topics.php

https://meta.trac.wordpress.org/ticket/7911

#2 @timse201
4 months ago

  • Component changed from Support Forums to International Forums

#3 @dd32
4 months ago

We re-use a lot of bbPress translations in those templates, we should probably change the textdomain for them all, or only for the custom strings.

It looks like in bbPress Participants is Voices, so changing the textdomain for that specific string is needed. The others might be able to be left as-is.

wporg-support-2024$ grep "'bbpress'" . -ri

./bbpress/form-user-roles.php:	<label for="role"><?php esc_html_e( 'Blog Role', 'bbpress' ); ?></label>
./bbpress/form-user-roles.php:	<label for="forum-role"><?php esc_html_e( 'Forum Role', 'bbpress' ); ?></label>
./bbpress/form-user-edit-account.php:		<?php esc_html_e( 'Account', 'bbpress' ); ?>
./bbpress/loop-topics.php:				<li class="bbp-topic-title"><?php esc_html_e( 'Topic', 'bbpress' ); ?></li>
./bbpress/loop-topics.php:				<li class="bbp-topic-voice-count"><?php esc_html_e( 'Participants', 'bbpress' ); ?></li>
./bbpress/loop-topics.php:					? esc_html_e( 'Replies', 'bbpress' )
./bbpress/loop-topics.php:					: esc_html_e( 'Posts',   'bbpress' );
./bbpress/loop-topics.php:				<li class="bbp-topic-freshness"><?php esc_html_e( 'Last Post', 'bbpress' ); ?></li>
./bbpress/form-user-edit.php:	<h2 class="entry-title"><?php esc_html_e( 'Name', 'bbpress' ); ?></h2>
./bbpress/form-user-edit.php:		<legend><?php esc_html_e( 'Name', 'bbpress' ); ?></legend>
./bbpress/form-user-edit.php:			<label for="first_name"><?php esc_html_e( 'First Name', 'bbpress' ); ?></label>
./bbpress/form-user-edit.php:			<label for="last_name"><?php esc_html_e( 'Last Name', 'bbpress' ); ?></label>
./bbpress/form-user-edit.php:			<label for="nickname"><?php esc_html_e( 'Nickname', 'bbpress' ); ?></label>
./bbpress/form-user-edit.php:			<label for="display_name"><?php esc_html_e( 'Display Name', 'bbpress' ); ?></label>
./bbpress/form-user-edit.php:	<h2 class="entry-title"><?php esc_html_e( 'Contact Info', 'bbpress' ); ?></h2>
./bbpress/form-user-edit.php:		<legend><?php esc_html_e( 'Contact Info', 'bbpress' ); ?></legend>
./bbpress/form-user-edit.php:			<label for="url"><?php esc_html_e( 'Website', 'bbpress' ); ?></label>
./bbpress/form-user-edit.php:		? esc_html_e( 'About Yourself', 'bbpress' )
./bbpress/form-user-edit.php:		: esc_html_e( 'About the user', 'bbpress' );
./bbpress/form-user-edit.php:			? esc_html_e( 'About Yourself', 'bbpress' )
./bbpress/form-user-edit.php:			: esc_html_e( 'About the user', 'bbpress' );
./bbpress/form-user-edit.php:			<label for="description"><?php esc_html_e( 'Biographical Info', 'bbpress' ); ?></label>
./bbpress/form-user-edit.php:	<h2 class="entry-title"><?php esc_html_e( 'Account', 'bbpress' ); ?></h2>
./bbpress/form-user-edit.php:		<legend><?php esc_html_e( 'Account', 'bbpress' ); ?></legend>
./bbpress/form-user-edit.php:			<label for="user_login"><?php esc_html_e( 'Username', 'bbpress' ); ?></label>
./bbpress/form-user-edit.php:			<label for="email"><?php esc_html_e( 'Email', 'bbpress' ); ?></label>
./bbpress/form-user-edit.php:			<label for="locale"><?php esc_html_e( 'Language', 'bbpress' ); ?></label>
./bbpress/form-user-edit.php:		<h2 class="entry-title"><?php esc_html_e( 'User Role', 'bbpress' ); ?></h2>
./bbpress/form-user-edit.php:			<legend><?php esc_html_e( 'User Role', 'bbpress' ); ?></legend>
./bbpress/form-user-edit.php:					<label for="super_admin"><?php esc_html_e( 'Network Role', 'bbpress' ); ?></label>
./bbpress/form-user-edit.php:						<?php esc_html_e( 'Grant this user super admin privileges for the Network.', 'bbpress' ); ?>
./bbpress/form-user-edit.php:		<legend><?php esc_html_e( 'Save Changes', 'bbpress' ); ?></legend>
./bbpress/form-user-edit.php:				? esc_html_e( 'Update Profile', 'bbpress' )
./bbpress/form-user-edit.php:				: esc_html_e( 'Update User',    'bbpress' );

#4 @dd32
4 months ago

Upon checking Translate, all of these bbpress textdomain strings are imported into the Forums component, so I'm just going to bulk change them.

https://translate.wordpress.org/projects/meta/forums/

#5 @dd32
4 months ago

  • Owner set to dd32
  • Resolution set to fixed
  • Status changed from new to closed

In 14399:

Forums: Use the wporg-forums textdomain instead of inheriting the bbPress textdomain.

Translate includes the strings in the wporg-forums project regardless of the textdomain specified, so we should just use the dedicated strings here.

Props timse201, dd32.
Closes https://github.com/WordPress/wordpress.org/pull/472
Fixes #7911.

#6 @timse201
4 months ago

Thanks @dd32

Note: See TracTickets for help on using tickets.