Core Trac Workflow Keywords Issue

[SirLouen]

This affects all tracs, but more specifically Core one
There a 4 keywords that have conflicting names:

• needs-testing and needs-testing-info
• has-design and has-design-feedback

Where is the problem?

Searches in the Custom Query are made whith a "contains" query filter. This means that searches are not based on exact matches. This means that if you search for either needs-testing or has-design you will receive results with needs-testing, needs-testing-info or the two. Same for has-designwith has-design-feedback

Solution

Simply modify this two keywords a little bit

For example, instead of:

needs-testing-info => needs-test-info or needs-info-tesing
and
has-design-feedback => has-feedback-design

The first one, the needs-testing one is specially important because both are conflicting and render queries of very poor quality.

[dd32]

Changing these to be less human readable isn't an ideal solution, I believe some of the reports have something akin to keywords LIKE needs-testing and keywords NOT LIKE needs-testing-info - perhaps the solution is to use existing built reports rather than freeform queries.

This needs to be discussed in #core and a direction formalised before any action can be taken on this ticket though.

[SirLouen]

Replying to dd32:

perhaps the solution is to use existing built reports rather than freeform queries.

This needs to be discussed in #core and a direction formalised before any action can be taken on this ticket though.

The problem with this, is that it doesn't provide the opportunity to check for certain types of tickets around needs-testing which happens to be a "key" keyword. For example, I was willing recently to review tickets that had both needs-testing and needs-testing-info at the same time specifically and was completely impossible.

In fact, I have to admit to you that this happens to be the most critical combination of keywords. The other one, I put as an example, was just another case of this inconvenience, but not as problematic as these two.

There are 2 solutions from my perspective:

1. Repairing the Trac query system, either by adding exact matches with quotes or the liking, or by just considering each exact keyword for each match between spaces

2. The simplest one that requires less coding: renaming either needs-testing or needs-testing info to avoid having them contained in each other. Just a little change like need-testing-info will also do the trick and I feel that I will not be less human-readable.

[joemcgill]

@dd32 After discussion in a few dev chats, this seems like a good change to make to support the workflows our test team uses to triage tickets, since the existing Trac query filters don't allow for showing needs-testing without also showing needs-testing-info.

It looks like both needs-testing-info and has-testing-info were added in https://meta.trac.wordpress.org/ticket/5634.

We'd like to see these two custom keywords adjusted to the following:

• needs-testing-info => needs-test-info
• has-testing-info => has-test-info
• needs-testing => No change.

Once these changes are made for the workflow keywords list and the associated JS that was added in https://meta.trac.wordpress.org/changeset/12154 to automatically remove keywords when others are added, I can handle transitioning any existing uses of the previous keywords on open tickets to the new versions (unless that's an easy thing to handle on your side).

[dd32]

Thanks @joemcgill - I'll see if I can take a look next week at what's needed here.

[dd32]

In 14448:

Trac: Reanme the needs-testing-info and has-testing-info to needs-test-info and has-test-info.

Props SirLouen, joemcgill, dd32.
Fixes #7935

[dd32]

I've updated meta.trac tickets:
#7583 #6135 #6241 #6348 #6390 #6656 #6867 #6961 #7922 #7928 #6153 #7319 #7492

I've confirmed that Meta & Core trac reports don't use the keyword.

The keywords are not listed on ​https://make.wordpress.org/core/handbook/contribute/trac/keywords/

@joemcgill For meta I just updated all tickets, skipping email notifications (ie. it's not in #meta-firehose in slack or ​wp-meta email archives. I can likely do the same for core if you want. Either for open tickets (256) or all tickets (~700). With or without an explanation comment.

The trac query I'm using is keywords=~testing-info&max=999 (add &status=!closed if just open ones), and then:

$new_keywords = str_ireplace(
        [ 'needs-testing-info', 'has-testing-info' ],
        [ 'needs-test-info', 'has-test-info' ],
        $ticket['keywords']
);

[dd32]

Updated BuddyPress; eg: ​https://buddypress.trac.wordpress.org/ticket/7910
Updated bbPress; eg: ​https://bbpress.trac.wordpress.org/ticket/3403

[joemcgill]

Replying to dd32:

I've updated meta.trac tickets:
#7583 #6135 #6241 #6348 #6390 #6656 #6867 #6961 #7922 #7928 #6153 #7319 #7492

I've confirmed that Meta & Core trac reports don't use the keyword.

The keywords are not listed on ​https://make.wordpress.org/core/handbook/contribute/trac/keywords/

Thanks! @SirLouen is working on updating the content on the handbook page for keywords. Thanks for flagging.

@joemcgill For meta I just updated all tickets, skipping email notifications (ie. it's not in #meta-firehose in slack or ​wp-meta email archives. I can likely do the same for core if you want. Either for open tickets (256) or all tickets (~700). With or without an explanation comment.

I think it would be best to go ahead and do this for all of the tickets for consistency if it's no more effort. @SirLouen has been manually updating some this week, and I bulk updated the ones that were in the next minor release milestone, but a full migration would be much cleaner.

[dd32]

Done, updated core.trac too.

Eg: ​https://core.trac.wordpress.org/ticket/61776