Making WordPress.org

Opened 2 months ago

Closed 2 months ago

#7950 closed defect (bug) (fixed)

Broken file reference for "Share this:" string in Rosetta plugin (class-locale-team.php)

Reported by: kimjiwoon's profile kimjiwoon Owned by: dd32's profile dd32
Milestone: Priority: normal
Component: Translate Site & Plugins Keywords:
Cc:

Description

While reviewing translation strings on translate.wordpress.org for the Korean locale, I found that the source file reference for the following string appears to be broken:

String: Share this:

References shown in GlotPress:

  • plugins/rosetta/inc/site/class-locale-main.php:102
  • plugins/rosetta/inc/site/class-locale-team.php:68

However, this path currently returns a 404 in Trac:
https://meta.trac.wordpress.org/browser/sites/trunk/global.wordpress.org/public_html/wp-content/plugins/rosetta/inc/site/class-locale-team.php?marks=68#L68

Error:

No node sites/trunk/global.wordpress.org/public_html/wp-content/plugins/rosetta/inc/site/class-locale-team.php at revision 14418

This suggests that the file has either been removed or relocated. It would be helpful to either update or remove the outdated file reference for clarity and maintenance purposes.

Reported from:
https://translate.wordpress.org/projects/meta/rosetta/ko/default/?page=3

Thank you for looking into this!

Change History (5)

#1 @kimjiwoon
2 months ago

Additional note regarding broken references:

Another missing file path was found related to site statistics:

sites/trunk/global.wordpress.org/public_html/wp-content/mu-plugins/jetpack-settings.php

Trac shows:

No node at revision 14418
https://meta.trac.wordpress.org/browser/sites/trunk/global.wordpress.org/public_html/wp-content/mu-plugins/jetpack-settings.php

This file is referenced in some translation contexts (e.g., strings like "Site Stats") but no longer exists in the repository. If this file has been removed or deprecated, it may be helpful to clean up or update the reference to prevent confusion for translators.

Thanks!

This ticket was mentioned in Slack in #meta by kimjiwoon. View the logs.


2 months ago

#3 @dd32
2 months ago

Unfortunately not all files are public, and GlotPress only allows a single file URL template per project.. We have some filters to adjust this, but unless someone raises it we often don't realise it's incorrect.

plugins/rosetta/inc/site/class-locale-team.php:68

This file is within

https://meta.trac.wordpress.org/browser/sites/trunk/wordpress.org/public_html/wp-content/plugins/rosetta/inc/site/class-locale-main.php

I've updated a filter that corrects the link location.

#4 @dd32
2 months ago

  • Component changed from International Sites (Rosetta) to Translate Site & Plugins

#5 @dd32
2 months ago

  • Owner set to dd32
  • Resolution set to fixed
  • Status changed from new to closed

In 14419:

Translate: Link to the correct location for some Rosetta strings, and don't link to private files.

Fixes #7950.

Note: See TracTickets for help on using tickets.