Incorrect committer attribution when using Release Confirmation

[jorgeatorres]

When using Release Confirmation, we've noticed that frequently the "Committer" column shows someone from the team that wasn't directly involved with the tagging of the new version.

For example, for the WooCommerce plugin, we've noticed that RC has attributed the following releases as follows:

• ​9.6.0 to konamiman and jorgeatorres. Actual committer: jorgeatorres.
• ​9.7.0 to jorgeatorresand albarin. Actual committer: albarin.
• ​9.7.1 to albarin and jorgeatorres. Actual committer: jorgeatorres.

​SVN clearly shows who the committer was when those tags were created.

How is RC obtaining the list of committers? This might be related to the internal tools we use to publish WooCommerce, but based on the above it does seem like SVN has the correct information to deduce the committer.

This doesn't impact our ability to submit releases and we haven't noticed any other issues with RC lately.

[Otto42]

for the WooCommerce plugin, we've noticed that RC has attributed the following releases

Where are you seeing this information about who is being attributed to anything?

[dd32]

9.7.1 to albarin and jorgeatorres. Actual committer: jorgeatorres.

It looks like this could be a SVN log parsing issue, but I don't think svn log is used in this code path..

Looking at 6.7.1:

​https://plugins.trac.wordpress.org/log/woocommerce/tags/9.7.1

The metadata has listed both ​r3245739 and ​r3250536 against v9.7.1, which is incorrect but kind of makes sense when you look at the above svn log.

However, that might be a coincidence, as looking at 9.8.1 has ​r3250536 (9.7.1) and ​r3269650 (9.8.1 copied from trunk) listed against it too. Note that the 9.8.0 commit is nowhere to be seen for 9.8.1.

I don't know why.. something odd

How is RC obtaining the list of committers?

​https://github.com/WordPress/wordpress.org/blob/7bcd368b66c9e098bce1314a9f4af61d7ac067a1/wordpress.org/public_html/wp-content/plugins/plugin-directory/cli/class-import.php#L200-L208

I'm suspecting the $last_release is incorrect somewhere where it's calling add_release() - as they get merged together if add_release() is called again.

[jorgeatorres]

Replying to Otto42:

for the WooCommerce plugin, we've noticed that RC has attributed the following releases

Where are you seeing this information about who is being attributed to anything?

I'm referring to the "Committer" column in ​https://wordpress.org/plugins/developers/releases/.

[jorgeatorres]

I'm suspecting the $last_release is incorrect somewhere where it's calling add_release() - as they get merged together if add_release() is called again.

Thanks for taking a look @dd32 and for sharing the details. Let me know if there's anything we can do on our end to help debug this further.