Making WordPress.org

Opened 4 months ago

Closed 4 months ago

#8044 closed defect (bug) (wontfix)

Batch modify form can be submitted without making any changes

Reported by: desrosj's profile desrosj Owned by:
Milestone: Priority: lowest
Component: Trac Keywords: close
Cc:

Description

It looks like the batch modify form can be submitted even if nothing in the form is filled out/selected.

  • Open a Trac report
  • Check a few tickets
  • Open Batch Modify at the bottom
  • Click "Change Tickets"

The result is a Batch Modify email gets sent out, but no changes are made or comment added tot he tickets.

Change History (3)

#1 @dd32
4 months ago

  • Keywords close added
  • Priority changed from normal to lowest

The Batch Modify functionality is provided by Trac.

Although we could probably prevent this by adding Javascript, I'm inclined to not do that, due to the ongoing maintenance burden of doing so.

This might also be fixed in a later version of Trac.

I suggest this is closed as wontfix.

#2 @dd32
4 months ago

In 14505:

Trac: Mark the Batch Modification comment field as required.

Props desrosj, dd32.
See #8044.
Fixes #8045.

#3 @dd32
4 months ago

  • Resolution set to wontfix
  • Status changed from new to closed

With the above change via #8045 the comment field is required, as such, all batch modifications should require at least a comment to be added (ie. Batch commenting).

That removes the need for any changes specific to this request.

Note: See TracTickets for help on using tickets.