Usernames with spaces result in an invalid emails on build repo mirror

[desrosj]

I think I noticed another scenario where usernames containing a space are problematic.

On commits authored by @bernhard-reiter, the WordPress/WordPress repository is not normalizing the @git.wordpress.org email to replace username spaces with hyphens (-).

His ​most recent commit from the git log:

commit a332dbc1695f535fd59433a19e2b551637902226
Author: Bernhard Reiter <Bernhard Reiter@git.wordpress.org>
Date:   Mon Sep 22 09:32:34 2025 +0000

    Block Bindings: Add `block_bindings_supported_attributes` filter.

    Add a block-agnostic version of the `block_bindings_supported_attributes_{$block_type}` filter first introduced in [60611].

    This allows adding block bindings support for attributes of multiple different blocks in one go.

    Follow-up to [60611].
    Props bernhard-reiter.
    See #62090.
    Built from https://develop.svn.wordpress.org/trunk@60790


    git-svn-id: http://core.svn.wordpress.org/trunk@60126 1a063a9b-81f0-0310-95a4-ce76da25c4cd

The wordpress-develop repository ​does appear to handle this correctly for the same commit:

commit 8bc30c91c8c40277034be9b8432597ca7d85eba0
Author: Bernie Reiter <bernhard-reiter@git.wordpress.org>
Date:   Mon Sep 22 09:30:06 2025 +0000

    Block Bindings: Add `block_bindings_supported_attributes` filter.

    Add a block-agnostic version of the `block_bindings_supported_attributes_{$block_type}` filter first introduced in [60611].

    This allows adding block bindings support for attributes of multiple different blocks in one go.

    Follow-up to [60611].
    Props bernhard-reiter.
    See #62090.

    git-svn-id: https://develop.svn.wordpress.org/trunk@60790 602fd350-edb4-49c9-b593-d223f7449a82

[dd32]

It's correct in ​git://core.git.wordpress.org/

(@bernhard-reiter Are you sure you don't want to update your profile with your name rather than the slugified version on ​https://profiles.wordpress.org/bernhard-reiter/ ?)

commit 07a63531cf40369facf4304c4f899f097456a610
Author: bernhard-reiter <bernhard-reiter@git.wordpress.org>
Date:   Mon Sep 22 09:32:34 2025 +0000

    Block Bindings: Add `block_bindings_supported_attributes` filter.

    Add a block-agnostic version of the `block_bindings_supported_attributes_{$block_type}` filter first introduced in [60611].

    This allows adding block bindings support for attributes of multiple different blocks in one go.

    Follow-up to [60611].
    Props bernhard-reiter.
    See #62090.
    Built from https://develop.svn.wordpress.org/trunk@60790


    git-svn-id: https://core.svn.wordpress.org/trunk@60126 1a063a9b-81f0-0310-95a4-ce76da25c4cd

Unfortunately github.com/WordPress/WordPress doesn't mirror the official git mirrors, but rather is a sync script running somewhere else which has no access to our database and the git author scripts, and importantly doesn't have the same commit hash history.

What this means, is that the Authorship of the commits is taken from SVN, which uses user_login as the author identifier, whereas we're using user_nicename in the git mirrors.

The options forward are threefold:

1. Update the existing sync script to use a kinda-nicename-conversion strtolower( str_replace( [' ', '.' ], '-', $name ) )
2. Bring the existing sync script in-house and use our get-author.sh script - This is not ideal as it would mean maintaining yet-another svn/git mirror
3. Switch WordPress/WordPress to mirroring core.git.wordpress.org - Which would result in the commit hashes for everything changing, or being stuck-in-time (ie. master would cease to be being updated, and we'd push to a new branch trunk).

I guess we're stuck using option 1 for now, at least until someone from systems wants to figure it out :) so.. @markjaquith FYI I guess?

Hmm.. I guess if we wanted to use option two, we could create a core-github.git.wordpress.org mirror, which maintained the existing commit hashes, and then continue to push that to the existing location.. The different branch naming would be problematic though, likewise the tagged versions would conflict.

[Bernhard Reiter]

(@bernhard-reiter Are you sure you don't want to update your profile with your name rather than the slugified version on ​https://profiles.wordpress.org/bernhard-reiter/ ?)

In hindsight, using my full name (including the space) was probably not the best choice when I created the account some 17 years ago. I seem to recall vaguely that in some cases, the slugified version was used automatically without my doing, but I'm not 100% sure.

Anyway, I don't mind changing the profile name, as long as that won't break anything else (will it?)

[dd32]

Replying to Bernhard Reiter:

Anyway, I don't mind changing the profile name, as long as that won't break anything else (will it?)

Setting your WordPress Display Name field will cause no issues what so ever.

Having a space in your WordPress.org username isn't an issue either, although it causes some weirdness with systems that don't expect it (as seen here). You're not the only committer with a "not WordPress standard" username :)