Opened 8 weeks ago
Last modified 6 weeks ago
#8211 new defect (bug)
Make sites: Site title link has incorrect colors on dark background
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Milestone: | Priority: | normal | |
| Component: | General | Keywords: | has-screenshots |
| Cc: |
Description
On Make sites (e.g., make.wordpress.org/core, make.wordpress.org/meta), the site title link in the local navigation bar has accessibility issues due to incorrect text colors on a dark background. It happens both on the "home" (link text color is black) and when visiting posts (link text color is blue).
To reproduce:
- Visit https://make.wordpress.org/core/ or https://make.wordpress.org/meta
- Observe the site title link color in the navigation bar (
.wp-block-wporg-local-navigation-bar .wp-block-site-title a) - Check contrast ratio, it fails accessibility standards.
- Repeat the same process but on a post page for any of the make sites, and confirm the same shows the text in blue.
Attachments (2)
Change History (5)
#2
@
7 weeks ago
Looks like these inline styles have been recently removed from the page, causing the issue:
.wp-elements-1b51aea1fd24d0aef3e0b3e7d65bcfef a:where(:not(.wp-element-button)) {
color:var(--wp--preset--color--white);
}
.wp-elements-1b51aea1fd24d0aef3e0b3e7d65bcfef a:where(:not(.wp-element-button)):hover {
color:var(--wp--preset--color--white);
}
#3
@
6 weeks ago
See also: https://github.com/WordPress/wporg-main-2022/issues/661
Related to this is https://x.com/davebloomdev/status/2037964248358207911
The fix was to re-enable the Gutenberg plugin on WordPress.org homepage.
Re-enabling gutenberg fixes these titles, but no-one is sure why/what/how the fault is.
I've delayed re-enabling Gutenberg on make.w.org until someone can figure out what's happening.
Best guess is it's something related to how the way Gutenberg removes Core filters in elements.php - maybe a priority clash is occurring.
https://github.com/WordPress/gutenberg/blob/trunk/lib/block-supports/elements.php#L262-L263
See also: https://github.com/WordPress/wporg-main-2022/issues/661