Remove irrelevant “tags” field from support forum review forms

[bor0]

The review form currently includes a “tags” field inherited from bbPress topic functionality, which is not relevant in the context of reviews and leads to confusing UX.

[bor0]

Regular forum post - tags still remain

[bor0]

Review post - no tags render

[bor0]

cc @dd32 - another one :)

[dd32]

@bor0 observations:

• bbp_* is a bbPress filter, but this is a custom filter. I suggest using wporg_bbp_ instead. existing bbp_ uses within the file are because the template is copied from bbPress.
• add_filter( 'bbp_topic_form_show_tags', array( $this, 'hide_topic_form_tags' ) ); having these be negated reads weirdly, I'd rename the function to 'show_topic_form_tags' instead, returning false explicitly for reviews.
• 'reviews' === bbp_get_view_id() exists within one of your branches where you're hiding it, so it's a little obtuse why it's there.

Finally; bbp_allow_topic_tags() has a filter (named bbp_allow_topic_tags).. so this is duplicating that needlessly :)

I would:

• Remove the 'reviews' === bbp_get_view_id() branch and just have Topic Tags string
• Use the bbp_allow_topic_tags filter
• Wrap the unwrapped code in bbp_allow_topic_tags()

I might've missed why you didn't go that route though, as I know there's some globals that can be weird in bbPress.

[bor0]

Addresses Dion's comments

[dd32]

If 8221.2.patch​ works (I haven't tested, but visually reviewed), ship it :)

[bor0]

In 14797:

Plugin Directory: Hide tags from Plugin reviews (plugin change)

Fixes #8221

Props @dd32