![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
Opened 7 weeks ago
Closed 7 weeks ago
#8252 closed defect (bug) (fixed)
Credits: Update library links to remove redirects
| Reported by: | peterwilsoncc | Owned by: | peterwilsoncc |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | API | Keywords: | has-patch |
| Cc: |
Description
Per this comment on the 7.0 Credits PR, several of the libraries included in the credits API redirect.
Let's update these to remove the extra HTTP request.
Props @wildworks
I'll submit a PR once 7.0 is out the door.
Change History (5)
This ticket was mentioned in PR #643 on WordPress/wordpress.org by @peterwilsoncc.
7 weeks ago
#1
- Keywords has-patch added
#2
@
7 weeks ago
I've created a pull request to make these changes, details are in the PR's description.
A key change is to the WordPress profiles link format. I've added a trailing slash to the URL to avoid a redirect, eg https://profiles.wordpress.org/wordpressdotorg -> https://profiles.wordpress.org/wordpressdotorg/
7 weeks ago
#3
Claudes review has flagged:
3 endpoints that 404 on the new URL — but they were already 404 on the old http URL too, so the PR is just doing the http→https upgrade and not introducing breakage:
My review:
- PclZip seems correct url, the site is undergoing updates.
- TouchPunch is 404 with
https://github.com/furf/jquery-ui-touch-punchbut https://github.com/furf/jquery-ui-touch-punch still links to that url though. - odyniec.net appears to have expired (Sept 2021 registration date) and taken over for other purposes. I'm sadly unable to find any activity from Michał online in the last few years, I would suggest updating this to the GitHub URL: https://github.com/odyniec/imgareaselect
profile.wordpress.org/usernamelinks toprofile.wordpress.org/username/See https://meta.trac.wordpress.org/ticket/8252