![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
#8273 closed defect (bug) (fixed)
Core commits not counted as contributions
| Reported by: | SergeyBiryukov | Owned by: | yani.iliev |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | Profiles | Keywords: | |
| Cc: |
Description (last modified by )
Noticed a couple of issues with the new profile pages:
- Core commits are not displayed in the All tab and not counted in the "Recent impact" widget, see the screenshots.
- The Code tab shows some core commits, but only if the committer's name has been mentioned in the props along with the other contributors. I think any core commit should be counted as a contribution for the committer too, whether or not they have included themselves in the props.
Attachments (2)
Change History (12)
#5
@
6 weeks ago
- Resolution → fixed
- Status accepted → closed
Fixed all feed to include core commits in r24767
Props SergeyBiryukov
#6
follow-up:
↓ 7
@
6 weeks ago
- Resolution fixed
- Status closed → reopened
Reopening this, instead of ticket:8267
This should be applicable for Meta commits too.
For there is a prop for @SergeyBiryukov , in this meta issue, yet in their profile section it is not displayed.
#7
in reply to: ↑ 6
@
6 weeks ago
- Resolution → fixed
- Status reopened → closed
Thanks for reopening. Meta commits are already handled the same way as core: a committer's meta.trac changesets count whether or not they're in the props (verified - e.g. SergeyBiryukov's profile currently shows 1,124 meta contributions across the Code/All tabs and Recent impact).
The specific commits here (r24766/r24767) are in the dotorg buddypress/website SVN (the profiles theme's own repo), not meta.trac - meta.trac is currently around r14903. The profile counts contributions from the Core, Meta, bbPress and BuddyPress Tracs plus GitHub; the website/deploy SVN isn't one of those sources, which is why props on those two commits don't show. Closing as already fixed for meta.trac. dotorg buddypress/website SVN is not public and tracking is currently not supported. This is not something that I can fix myself. @dd32 would know better if this is something we want to add now or in the future.
Replying to alanjacobmathew:
Reopening this, instead of ticket:8267
This should be applicable for Meta commits too.
For there is a prop for @SergeyBiryukov , in this meta issue, yet in their profile section it is not displayed.
#8
follow-up:
↓ 9
@
6 weeks ago
I'm not reopening this ticket, but I wanted to clarify a quick communication gap regarding my previous report.
My issue wasn't about commit logs or code props. I was referring to the public user profile feed failing to log standard ticket activity—specifically the opening and closing of tickets on Core and Meta Trac.
Like how it shows the activity log for wp-develop and gutenberg issues and PR made on github
I previously used to see on my activity log, whenever a trac issue is created for meta or core. Not credits, just that activity.
For taking the example of the same ticket, when sergey created this ticket, it should have been displayed on his activity 'Created an ticket on meta trac'
The Activity and Meta are stored in 2 separate tables that cannot be joined together (hyper-db limitation). The previous activity was pulling 15 or so records from both tables and joining them together. This is still possible. The downside is that we will only be displaying the most recent 15-20 records. Right now, the activity is displaying all the data.
Unfortunately, it is one or the other, not both are possible. I am happy to return the previous option of 15-20 items if it gets upvoted by others or keep it as is to browse all records.
The contributions numbers are not perfect. They will improve in the next 2 or so weeks once I start talking to each Make team to refine what data is high/medium/low impact.