Opened 9 years ago

Closed 8 years ago

#828 closed defect (bug) (fixed)

Keyboard Shortcuts on Make blogs

Reported by: afercia's profile afercia Owned by:
Milestone: Priority: normal
Component: Make (Get Involved) / P2 Keywords: needs-accessibility


On make blog pages, there's a "Keyboard Shortcuts" link in the top right, click on that link and an overlay opens with a list of available Keyboard Shortcuts, see for example:

Same on index pages.

Can't get any of those Keyboard Shortcuts to work, tried every key combination without luck.
@sam suggested they might never have worked:

Maybe worth considering to just remove that link and all the related stuff?

Change History (8)

#1 @Otto42
9 years ago

Related: #759

#2 @Otto42
9 years ago

Some keyboard shortcuts do work, but have different keys due to browser interference? Not certain on this.

For example, if I'm looking at this page:

Scroll down to a post which has comments. In Chrome on Windows 8, pressing SHIFT-O will toggle comment display on and off. So, that one works.

Ultimately this appears to be a problem with the P2 theme itself (the shortcode code is in p2.js). We may need to update or fix it or move on to another theme.

#3 @afercia
9 years ago

Had a quick look at p2.js and it looks like it's a bit dated :), see p2.keyboard: onkeypress, wrong charcodes (always checks for uppercase values ), missing targeted elements, etc.
Anyway, thanks very much Otto.

#4 @Otto42
9 years ago

#759 was marked as a duplicate.

#5 @Otto42
9 years ago

If somebody wants to take a swing at fixing the p2.js, we can work it into an update for our child theme easily enough, or push the changes back upstream into P2.

#6 @melchoyce
9 years ago

  • Keywords needs-accessibility added

#7 @swissspidy
8 years ago

I remember that keyboard shortcuts used to work once as I always used the j and k keys to navigate between posts. Too bad this has been broken for quite some time.

O2 for the make blogs is around the corner (see make/meta), and keyboard shortcuts work there, but there are a few missing (like j and k shortcuts).

#8 @samuelsidler
8 years ago

  • Resolution set to fixed
  • Status changed from new to closed

I'm going to resolve this as fixed, because it will be fixed with the upgrade to O2. If there are specific keyboard shortcuts missing, file an upstream O2 ticket and we'll pick up the change when it's fixed there.

Note: See TracTickets for help on using tickets.