Opened 9 years ago

Closed 9 years ago

#895 closed enhancement (fixed)

Direct links to preview don't trigger the preview overlay

Reported by: chriscct7's profile chriscct7 Owned by: obenland's profile obenland
Milestone: Priority: normal
Component: Theme Directory Keywords:


Links like (the link shown when on Anchorage's Preview) should automatically open a preview of Anchorage instead of showing the theme details page like it does right now

Change History (4)

#1 @chriscct7
9 years ago

That theme has previewception going on. There's a theme made preview on the preview page.

#2 @obenland
9 years ago

So far I thought about

  • redirecting previews to their theme pages and just make previews only accessible through the JS app.
  • adding a rewrite rule that would pass on the theme name, show the theme page, and let the JS app pick up on the preview context through the url. We should mitigate duplicate content issues here though.
  • adding a rewrite rule that would pass on the theme name and preview context, and we could then create a custom template for that. I'm not sure how that'll work together with the JS app though.

@dd32, do you have a better idea? What would you recommend the best way to go about it would be?

#3 @dd32
9 years ago

  • Disable the /preview/ link, and replace it with a link, handle the preview within JS only
  • Handle the condition, with a rewrite rule
  • Handle the condition within PHP/WordPress with a rewrite rule

Ditch server-side rendering for anything that isn't required, and use the fallbacks where appropriate, in this case, a direct link to as a non-JS fallback seems correct.

#4 @obenland
9 years ago

  • Owner set to obenland
  • Resolution set to fixed
  • Status changed from new to closed

In 1453: Themes: Don't create a /preview/ URL for previews.

The default has always been Let's keep it that way and handle
the integrated preview in JS only.

Also provides a better fix for #901. If themes are advanced in preview, the
modal keeps up with that now.

Fixes #895.

Note: See TracTickets for help on using tickets.