WordPress.org

Making WordPress.org

Opened 5 years ago

Closed 5 years ago

#914 closed defect (fixed)

Re-enable skipping duplicate hooks when parsing

Reported by: DrewAPicture Owned by: coffee2code
Milestone: Priority: normal
Component: Developer Hub Keywords: has-patch
Cc:

Description

Background

In mid-December 2014, the logic that skips parsing duplicate hooks in WP-Parser was disabled. WordPress core relies on skipping those duplicates so that references don't get overwritten with the "This action|filter is documented in ..." phrase instead of the intended hook doc.

It was pointed out this morning by @adamsilverstein, that some references were overwritten with the duplicate comment when we re-parsed for 4.1 at the end of the year. For instance: https://developer.wordpress.org/reference/hooks/_wp_post_revision_field_field/

Next Steps

In response to Adam's feedback, I added a new filter to WP-Parser to allow us to re-enable skipping of duplicate hooks when parsing: wp_parser_skip_duplicate_hooks.

Patch attached for the devhub theme.

Attachments (1)

914.diff (351 bytes) - added by DrewAPicture 5 years ago.

Download all attachments as: .zip

Change History (4)

@DrewAPicture
5 years ago

This ticket was mentioned in Slack in #meta-devhub by drew. View the logs.


5 years ago

This ticket was mentioned in Slack in #meta-devhub by drew. View the logs.


5 years ago

#3 @coffee2code
5 years ago

  • Owner set to coffee2code
  • Resolution set to fixed
  • Status changed from new to closed

In 1503:

developer.wordpress.org: Re-enable skipping duplicate hooks when parsing (prevents overwriting docs for primary instance).

Fixes #914.
Props DrewAPicture.

Note: See TracTickets for help on using tickets.