Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#943 closed defect (bug) (fixed)

Latest Themes list showing updated themes as well.

Reported by: shaped-pixels's profile Shaped Pixels Owned by: obenland's profile obenland
Milestone: Priority: high
Component: Theme Directory Keywords:


I was just talking with Obenland in Slack about something I was curious as to why updated themes were integrated into the latest list. He said it should just be displaying "newly released" themes, but it's loading both new and updated themes. ...He believes there could be a bug with the "Latest" theme list in the new theme directory. Check it out and you will find a ton of updated themes mixed in.

My argument is that for people coming to view the latest themes are looking for "New" themes. If I were one, I would not want to see old themes there that simply been updated, I would want to see just new themes.

Change History (9)

#1 @obenland
9 years ago

  • Cc Otto42 added
  • Priority changed from normal to high

I was hoping the API query for new themes was faulty, because that would have been fairly easy to fix. Unfortunately it looks like something is messing with the publish date of themes, and on a first glance I was not able to figure out what it is.

I'll have a few hours time tonight to look at it and hope I can figure it out. It does look like we won't get around running a script over it to reset the publish time on themes that were published and updated recently, though.

#2 @Shaped Pixels
9 years ago

Thanks for the update...there is always something that is never easy is there! As for the last part of resetting current published and updated themes, I doubt that will be a major issue. Actually, to try a reset would just be too much of a job to do I would imagine. Obviously it's best to solve the issue and then any new themes published will be OK.

#3 @obenland
9 years ago

  • Owner set to obenland
  • Status changed from new to accepted

#4 @obenland
9 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

I ran a script over all published themes and updated their publish date to the topic start date of their bbpress predecessors. This should be fixed for now, but we should keep an eye on it and reopen this ticket if need be.

#5 @Shaped Pixels
9 years ago

A work horse developer you are...thanks for the update! We will watch it as you said and see how things go with the next round of theme releases.


#6 @obenland
9 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Found the bug and have a fix for it. Will commit it once I'm back in front of a computer again.

#7 @obenland
9 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 1397: Themes: Don't update theme post until new version was approved.

Theme description and tags might change in new versions, so the post can't be
updated with that new information until that version has been approved.

This also fixes a bug where the post date would be set to the upload date of
the new version, mixing new themes with updated themes in the Latest Themes
view in the Directory.

Fixes #943.

#8 @obenland
9 years ago

In 1398: Themes: Update post to also update post_time.

wp_publish_post() only transitions the post status, leaving us with
inacurate post dates of new themes.

See #943.

#9 @obenland
9 years ago

In 1403: Themes: Use the date of first approval as release date.

See #943, r1398.

Note: See TracTickets for help on using tickets.