WordPress.org

Making WordPress.org

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#964 closed defect (invalid)

Themes in directory showing up for tags on future versions

Reported by: joedolson Owned by:
Milestone: Priority: normal
Component: Theme Directory Keywords:
Cc:

Description

While checking out the accessibility-ready tag themes, I noticed some in there that I know have recently added the tag, but have not yet been approved for it. (SemPress, Storefront, for example.)

Checking the current version of the theme, I can see that those versions do not use the accessibility-ready tag, but the theme shows up in the filter for the tag.

This seems like it's probably related to https://meta.trac.wordpress.org/ticket/943, so I think that the root problem may already be fixed, but the data needs some clean up.

This is obviously not limited to accessibility-ready themes; that's just where I noticed it. I would assume that this is true for any theme that has added a new version with new tags that hasn't been approved and made live.

Change History (6)

#1 @joedolson
5 years ago

Probably should have cc'ed @obenland on this.

#2 in reply to: ↑ description @obenland
5 years ago

  • Resolution set to invalid
  • Status changed from new to closed

Replying to joedolson:

This seems like it's probably related to https://meta.trac.wordpress.org/ticket/943, so I think that the root problem may already be fixed, but the data needs some clean up.

Correct, this was fixed in r1397 for #943. The clean up will happen over time as the versions that add the tag are approved and set live. Updates to live themes usually go through fairly quickly.

Themes that are not approved yet do not show up on the directory at all (like the 123 unapproved themes with the accessibility-ready tag).

#3 follow-up: @joedolson
5 years ago

I'm concerned, however, about themes that are currently approved, add a tag, and then have their new version denied.

SemPress, for example, had their new version rejected. While this version may eventually be updated and approved, this isn't necessarily true globally - many themes never complete their updates. Is there anything we can do about this?

#4 in reply to: ↑ 3 ; follow-up: @obenland
5 years ago

Replying to joedolson:

SemPress, for example, had their new version rejected. While this version may eventually be updated and approved, this isn't necessarily true globally - many themes never complete their updates.

The fact that SemPress is in there, even though it was not-approved 4 months ago, tells me that the data leak existed in the old directory as well. Since SemPress hasn't been updated since then, the tags where part of the import data.

Is there anything we can do about this?

I can remove the tag from SemPress and Storefront manually.

#5 in reply to: ↑ 4 @obenland
5 years ago

Replying to obenland:

I can remove the tag from SemPress and Storefront manually.

Done, caches will need about an hour to regenerate.

#6 @joedolson
5 years ago

Thanks, appreciate that a lot.

Note: See TracTickets for help on using tickets.