WordPress.org

Making WordPress.org

Opened 3 years ago

Last modified 5 months ago

#977 reviewing enhancement

dot removed from username in WordCamp.org (Edit Organizer -> wordpress.org user name)

Reported by: j.conti Owned by: coreymckrill
Milestone: Priority: low
Component: WordCamp Site & Plugins Keywords: good-first-bug has-patch needs-testing
Cc:

Description

Hi,

When I add my user name (j.conti) in the field wordpress.org user name at WordCamp.org admin -> Edit organizer, the dot is removed.

Attachments (2)

Edit_Organizer_‹_WordCamp_Barcelona_2015_—_WordPress.png (70.7 KB) - added by j.conti 3 years ago.
977.diff (1.2 KB) - added by hlashbrooke 5 months ago.
Updating username to display to use user_login instead of user_nicename

Download all attachments as: .zip

Change History (13)

#1 @iandunn
3 years ago

  • Keywords needs-patch good-first-bug added
  • Owner set to iandunn
  • Status changed from new to accepted

Possibly related to #681 and #683

This ticket was mentioned in Slack in #meta by iandunn. View the logs.


3 years ago

#3 @iandunn
3 years ago

This is probably caused by the difference between the actual username and the nicename, and it's probably the same bug that's affecting speaker badges.

x-ref: https://wordpress.slack.com/archives/events/p1442408995000969

This ticket was mentioned in Slack in #meta by sergey. View the logs.


2 years ago

#5 @iandunn
2 years ago

In 2743:

WordCamp.org: Centralize user fetching functionality.

Previously wordcamp-participation-notifier and wc-post-types were using slightly different code to get the same data, which resulted in a bug where wc-post-types would find the user, but wordcamp-participation-notifier wouldn't. That led to some profile badges being removed when the speaker/organizer post was updated, because the notifier would think the username was removed from the field, and send a command to remove the badge.

Because the two plugins are interdependent, they need to use a common function to guarantee identical results.

get_saved_wporg_user_id() doesn't need to use the new function, because tix_username is always set from user_login, rather than being entered as user-input.

See #977

#6 @iandunn
2 years ago

  • Priority changed from normal to low
  • Type changed from defect to enhancement

The form will accept either the username (user_login) or the normalized slug of the username (user_nicename), but it always displays the slug. That's expected, so there's no bug here, but it would probably be better to always display the username instead, to avoid confusion.

Note that there was a bug related to this, which was fixed in r2743.

This ticket was mentioned in Slack in #themereview by cristiano.zanca. View the logs.


2 years ago

#8 @iandunn
8 months ago

Also related, #703

@hlashbrooke
5 months ago

Updating username to display to use user_login instead of user_nicename

#9 @hlashbrooke
5 months ago

  • Keywords has-patch needs-testing added; needs-patch removed

The patch above (977.diff) updates the display of the username to use user_login instead of user_nicename in all three locations:

  • Organiser edit page
  • Speaker edit page
  • Speaker list table

I don't think there are any other locations, so that should cover everything.

#10 @coreymckrill
5 months ago

  • Owner changed from iandunn to coreymckrill
  • Status changed from accepted to assigned

#11 @coreymckrill
5 months ago

  • Status changed from assigned to reviewing
Note: See TracTickets for help on using tickets.