dot removed from username in WordCamp.org (Edit Organizer -> wordpress.org user name)

[j.conti]

Hi,

When I add my user name (j.conti) in the field wordpress.org user name at WordCamp.org admin -> Edit organizer, the dot is removed.

[iandunn]

Possibly related to #681 and #683

[iandunn]

This is probably caused by the difference between the actual username and the nicename, and it's probably the same bug that's affecting speaker badges.

x-ref: ​https://wordpress.slack.com/archives/events/p1442408995000969

[iandunn]

In 2743:

WordCamp.org: Centralize user fetching functionality.

Previously wordcamp-participation-notifier and wc-post-types were using slightly different code to get the same data, which resulted in a bug where wc-post-types would find the user, but wordcamp-participation-notifier wouldn't. That led to some profile badges being removed when the speaker/organizer post was updated, because the notifier would think the username was removed from the field, and send a command to remove the badge.

Because the two plugins are interdependent, they need to use a common function to guarantee identical results.

get_saved_wporg_user_id() doesn't need to use the new function, because tix_username is always set from user_login, rather than being entered as user-input.

See #977

[iandunn]

The form will accept either the username (user_login) or the normalized slug of the username (user_nicename), but it always displays the slug. That's expected, so there's no bug here, but it would probably be better to always display the username instead, to avoid confusion.

Note that there was a bug related to this, which was fixed in r2743.

[iandunn]

Also related, #703

[hlashbrooke]

Updating username to display to use user_login instead of user_nicename

[hlashbrooke]

The patch above (977.diff) updates the display of the username to use user_login instead of user_nicename in all three locations:

• Organiser edit page
• Speaker edit page
• Speaker list table

I don't think there are any other locations, so that should cover everything.

[iandunn]

Fixed in ​https://github.com/WordPress/wordcamp.org/commit/9ab61304b435f98ffb02d1f6b44fa84e95a8d483